Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lint-changed from scripts/docs #25308

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Dec 29, 2022

  • Closes

User facing changelog

n/a

Additional details

  • @lmiller1990 noticed that this script is broken, I confirmed it was broken before this PR too: chore: improve linting #25235 (review)
  • Our docs aren't totally correct on it either - lint-staged already runs eslint --fix, so there's not a situation where a functional lint-changed would be needed anyways.
  • I kept the source code in npm/eslint-plugin-dev because tests for it do pass and it's possible it's being used outside of the monorepo.

Steps to test

How has the user experience changed?

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 29, 2022

Thanks for taking the time to open a PR!

@flotwig flotwig mentioned this pull request Dec 29, 2022
1 task
Base automatically changed from simplify-linting to develop December 29, 2022 17:26
@@ -42,7 +42,6 @@
"get-next-version": "node scripts/get-next-version.js",
"postinstall": "node ./scripts/run-postInstall.js",
"lint": "lerna run lint --no-bail --concurrency 2",
"lint-changed": "lint-changed",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you log an issue to fix the broken script? Or remove in a MVB? Find with removing but if it's not working and its from something we ship, seems like this will get lost.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed that because the tests in eslint-plugin-dev pass, that the scripts aren't totally broken, but on second glance I actually cannot successfully invoke them no matter what I try. It looks like @cypress-io/tools is looking at removing eslint-plugin-dev entirely, so I commented to ask if we can blast these scripts into orbit as part of that change: #24251 (comment)

@cypress
Copy link

cypress bot commented Dec 29, 2022



Test summary

10255 0 177 0Flakiness 13


Run details

Project cypress
Status Passed
Commit d02a164
Started Dec 29, 2022 6:12 PM
Ended Dec 29, 2022 6:25 PM
Duration 13:04 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

migration.cy.ts Flakiness
1 Full migration flow for each project > completes journey for migration-e2e-defaults-with-projectId
scaffold-component-testing.cy.ts Flakiness
1 scaffolding component testing > vuecli4vue2 > scaffolds component testing for Vue CLI 4 w/ Vue 2 project
commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
e2e/origin/cookie_behavior.cy.ts Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
2 ... > same site / cross origin > fetch > sets same-site cookies if "include" credentials option is specified from request, but does not attach same-site cookies to request by default (same-origin)
This comment includes only the first 5 flaky tests. See all 13 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig merged commit 7721e2b into develop Jan 4, 2023
@flotwig flotwig deleted the rm-lint-changed branch January 4, 2023 15:39
tgriesser added a commit that referenced this pull request Jan 18, 2023
* develop: (45 commits)
  fix: re-enable CYPRESS_INTERNAL_VITE_DEV development (#25364)
  fix: add skip domain injection description (#25463)
  fix: revert CSP header and script-src addition (#25445)
  chore: Update v8 snapshot cache (#25401)
  feat: Do not strip CSP headers from HTTPResponse (#24760)
  fix: keep spaces in formatted output in test runner (#24687)
  fix: Restrict dependency versions to known supported ranges (#25380)
  chore: Update v8 snapshot cache (#25370)
  feat: experimental skip domain injection (#25307)
  chore: support vite v4 for component testing (#25365)
  feat: Use JSX/TSX in generated spec filenames (#25318)
  docs(angular): Properties that are spied upon have to be defined within `componentProperties` instead of on root level. (#25359)
  chore: remove lint-changed from scripts/docs (#25308)
  chore: bump to 12.3.0 [skip ci] (#25355)
  fix: make NODE_ENV "production" for prod builds of launchpad (#25320)
  fix: .contains() should only return one element at all times (#25250)
  feat: add currentRetry to Cypress API (#25297)
  chore: release @cypress/webpack-dev-server-v3.2.2
  chore: release create-cypress-tests-v2.0.1
  fix: change wording for spec creation (#25271)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants