Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: onUnmounted warning in topnav #18988

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Conversation

elevatebart
Copy link
Contributor

@elevatebart elevatebart commented Nov 18, 2021

When opening the launchpad I get warnings on the homepage

[Vue warn]: onUnmounted is called when there is no active component instance to be associated with. Lifecycle injection APIs can only be used during execution of setup(). If you are using async setup(), make sure to register lifecycle hooks before the first await statement. 
  at <Anonymous gql= Object show-browsers=false > 
  at <Anonymous key=0 gql= Object show-browsers=false  ... > 
  at <Anonymous> 
  at <Anonymous> 
  at <App>

Screen Shot 2021-11-18 at 1 15 27 PM

Fix

One cannot define a new computed inside of a computed property.
Don't use composables directly inside a computed.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 18, 2021

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Nov 18, 2021



Test summary

8456 1 100 4Flakiness 1


Run details

Project cypress
Status Failed
Commit 7d88dc1
Started Nov 18, 2021 11:35 PM
Ended Nov 18, 2021 11:46 PM
Duration 11:35 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

cypress/integration/commands/net_stubbing_spec.ts Failed
1 network stubbing > intercepting request > should delay the same amount on every response

Flakiness

cypress/integration/commands/net_stubbing_spec.ts Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@elevatebart elevatebart marked this pull request as ready for review November 18, 2021 20:30
@lmiller1990 lmiller1990 merged commit d06c0a9 into 10.0-release Nov 18, 2021
@lmiller1990 lmiller1990 deleted the fix/topnav-warning branch November 18, 2021 23:57
tgriesser added a commit that referenced this pull request Nov 21, 2021
* 10.0-release:
  feat: use fuzzy search (#18966)
  fix: onUnmounted warning in topnav (#18988)
  fix: CYPRESS_INTERNAL_VITE_DEV for development
  feat: Create default config file (#18943)
  feat(app): support editor preference (#18932)
tgriesser added a commit that referenced this pull request Nov 21, 2021
…e-data-clean-refactor

* tgriesser/chore/e2e-data-clean: (76 commits)
  chore: post-merge cleanup
  feat: use hoisted yarn install in binary build (#17285)
  fix: fix spec list header, "Create specs" prompt, add workspace recommended apollo extension (#18993)
  feat(unify): reporter settings (#18946)
  feat: add devServer to config file (#18962)
  fix: compile npm packages for node 12 (#18989)
  fix: show call count even if `cy.stub().log(false)`. (#18907)
  chore: Update TypeScript to 4.4.4 (#18930)
  feat: use fuzzy search (#18966)
  fix: onUnmounted warning in topnav (#18988)
  fix: wrap playground selectors in double quotes if not included (#18442)
  fix: flaky settings_spec test (#18979)
  fix: CYPRESS_INTERNAL_VITE_DEV for development
  feat: Create default config file (#18943)
  feat(app): support editor preference (#18932)
  chore: Update Chrome (stable) to 96.0.4664.45 (#18931)
  fix: Loading of specs with % in the filename (#18877)
  feat: improve vite DX (#18937)
  chore: refactor `create` into class `$Cy` (#18715)
  feat: Use plugins on config files (#18798)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants