Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve vite DX #18937

Merged
merged 12 commits into from
Nov 17, 2021
Merged

feat: improve vite DX #18937

merged 12 commits into from
Nov 17, 2021

Conversation

tgriesser
Copy link
Member

  • Uses vite build for normal workflow, unless CYPRESS_INTERNAL_VITE_DEV=true
    • Vite build has faster startup time and is more reflective of the actual output we'll be building, but it doesn't have sourcemaps / doesn't trigger auto page refreshes on changes (we can add a watcher for this)
    • Use CYPRESS_INTERNAL_VITE_DEV=1 yarn dev when doing component work
  • Prefetches data for initial launchpad load
  • Namespace the app data folder for internal tests
  • Improves startup & relaunching the Cypress app, also if we exit the binary it will auto reload if we touch a file in server / data-context
  • Moves __vite__ assets to /__cypress/assets

@tgriesser tgriesser requested a review from a team as a code owner November 16, 2021 14:51
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 16, 2021

Thanks for taking the time to open a PR!

@tgriesser tgriesser requested review from jennifer-shehane and tbiethman and removed request for a team November 16, 2021 14:51
@tgriesser tgriesser changed the base branch from unified-desktop-gui to 10.0-release November 16, 2021 14:53
@cypress
Copy link

cypress bot commented Nov 16, 2021



Test summary

18649 0 216 7Flakiness 4


Run details

Project cypress
Status Passed
Commit c3bc186
Started Nov 17, 2021 4:16 PM
Ended Nov 17, 2021 4:29 PM
Duration 12:25 💡
OS Linux Debian - 10.9
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing_spec.ts Flakiness
1 network stubbing > intercepting response > can delay and throttle a static response
2 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
cypress/proxy-logging-spec.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code
2 ... > works with forceNetworkError

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

* 10.0-release:
  feat: Use plugins on config files (#18798)
  BREAKING CHANGE: trigger major bump
  BREAKING CHANGE: trigger major bump
  fix: fix cypress/package.json crasher
  fix(breaking): change circle.yml to release binary
  fix: build-prod-ui deps before build-prod packages
  feat: implement spec list tree (#18901)
  chore: adding 10.0-release to the circle.yml build script (#18926)
JessicaSachs
JessicaSachs previously approved these changes Nov 17, 2021
@tgriesser tgriesser merged commit 2eb0ff5 into 10.0-release Nov 17, 2021
@tgriesser tgriesser deleted the tgriesser/feat/improve-vite-dx branch November 17, 2021 16:24
tgriesser added a commit that referenced this pull request Nov 17, 2021
* 10.0-release:
  feat: improve vite DX (#18937)
  feat: Use plugins on config files (#18798)
  BREAKING CHANGE: trigger major bump
  BREAKING CHANGE: trigger major bump
  fix: fix cypress/package.json crasher
  fix(breaking): change circle.yml to release binary
  fix: build-prod-ui deps before build-prod packages
  feat: implement spec list tree (#18901)
  chore: adding 10.0-release to the circle.yml build script (#18926)
  feat(app): remove __vite__ route and default to unified runner (#18909)
  fix: app layout + specs list review (#18862)
  feat(app): show previous versions (#18838)
  feat: scaffold integration files in app (#18763)
  feat: add footer to the settings (#18867)
  fix: Exit when both --e2e and --component flags are passed in (#18855)
tgriesser added a commit that referenced this pull request Nov 21, 2021
…e-data-clean-refactor

* tgriesser/chore/e2e-data-clean: (76 commits)
  chore: post-merge cleanup
  feat: use hoisted yarn install in binary build (#17285)
  fix: fix spec list header, "Create specs" prompt, add workspace recommended apollo extension (#18993)
  feat(unify): reporter settings (#18946)
  feat: add devServer to config file (#18962)
  fix: compile npm packages for node 12 (#18989)
  fix: show call count even if `cy.stub().log(false)`. (#18907)
  chore: Update TypeScript to 4.4.4 (#18930)
  feat: use fuzzy search (#18966)
  fix: onUnmounted warning in topnav (#18988)
  fix: wrap playground selectors in double quotes if not included (#18442)
  fix: flaky settings_spec test (#18979)
  fix: CYPRESS_INTERNAL_VITE_DEV for development
  feat: Create default config file (#18943)
  feat(app): support editor preference (#18932)
  chore: Update Chrome (stable) to 96.0.4664.45 (#18931)
  fix: Loading of specs with % in the filename (#18877)
  feat: improve vite DX (#18937)
  chore: refactor `create` into class `$Cy` (#18715)
  feat: Use plugins on config files (#18798)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants