Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert "chore: Vite upgrade (#1381)" (#1383)" #1396

Merged
merged 2 commits into from
Sep 7, 2023

Conversation

AtofStryker
Copy link
Contributor

This reverts commit 1135329.

this reimplements the vite update to be tested alongside the node/electron upgrade in cypress/cypress-io originally done in #1381

see cypress-io/cypress#27715

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage: 92.85% and project coverage change: +4.20% 🎉

Comparison is base (79afc2c) 89.68% compared to head (ce4b5a9) 93.89%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1396      +/-   ##
===========================================
+ Coverage    89.68%   93.89%   +4.20%     
===========================================
  Files           19       95      +76     
  Lines          737     1606     +869     
  Branches        35      256     +221     
===========================================
+ Hits           661     1508     +847     
- Misses          76       98      +22     
Files Changed Coverage Δ
backend/helpers.ts 96.29% <ø> (ø)
src/machines/authMachine.ts 97.36% <ø> (ø)
src/utils/asyncUtils.ts 77.77% <80.00%> (ø)
backend/app.ts 100.00% <100.00%> (ø)
src/index.tsx 100.00% <100.00%> (ø)
src/utils/portUtils.ts 71.42% <100.00%> (-1.91%) ⬇️

... and 74 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cypress
Copy link

cypress bot commented Sep 2, 2023

Passing run #6147 ↗︎

0 448 2 0 Flakiness 0

Details:

Update package.json
Project: cypress-realworld-app Commit: ce4b5a994e
Status: Passed Duration: 31:37 💡
Started: Sep 3, 2023 10:45 PM Ended: Sep 3, 2023 11:16 PM

Review all test suite changes for PR #1396 ↗︎

package.json Outdated Show resolved Hide resolved
@AtofStryker
Copy link
Contributor Author

will wait to merge this in until cypress-io/cypress#27715 is approved and ready to ship

@AtofStryker AtofStryker merged commit e66f559 into develop Sep 7, 2023
46 checks passed
@AtofStryker AtofStryker deleted the chore/reimplement_vite_update branch September 7, 2023 19:18
ramosbugs added a commit to unflakable/unflakable-javascript that referenced this pull request Sep 9, 2023
ramosbugs added a commit to unflakable/unflakable-javascript that referenced this pull request Sep 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Node.js 18 or later
3 participants