chore: update RWA to node 18 #1395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MikeMcC399
reviewed
Sep 3, 2023
| @@ -12,7 +12,7 @@ | |||
| "url": "https://github.com/cypress-io/cypress-realworld-app/issues" | |||
| }, | |||
| "engines": { | |||
| "node": "^16.16.0" | |||
| "node": "^18.15.0" | |||
There was a problem hiding this comment.
Depending on any app update, it may be possible to include also Node.js 20 and later e.g.
"node": "^18.15.0 || >=20.0.0"
MikeMcC399
reviewed
Sep 3, 2023
| @@ -46,7 +46,7 @@ jobs: | |||
| # which has some compatibility issues with openSSL inside this windows job. | |||
| # Node 18 updated with OpenSSL provider which causes this compatibility issue | |||
| # downgrading node to v16 to use the openssl-legacy-provider by default to prevent this issue | |||
| node-version: '16.16.0' | |||
| node-version: '18.15.0' | |||
There was a problem hiding this comment.
The previous lines of comment no longer apply and should be removed.
|
@MikeMcC399 I am going to close this in favor of #1396. I should be able to update the engines there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates RWA to node 18