Resolve Makefile error on Ubuntu #3780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MahdiBaghbani
requested review from
labkode,
glpatcern and
gmgigi96
as code owners
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
MahdiBaghbani
changed the title
|
@MahdiBaghbani Great solution! Can you add a changelog entry? @labkode we should also review if this is OK for the automated build scripts, but I guess they probably already use bash anyway? |
gmgigi96
requested changes
Apr 6, 2023
pull request link should come first.
gmgigi96
approved these changes
Apr 11, 2023
gmgigi96
pushed a commit
to gmgigi96/reva
that referenced
this pull request
Jun 5, 2023
gmgigi96
pushed a commit
to gmgigi96/reva
that referenced
this pull request
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makefile will be using bash as it's shell instead of sh which is defaulted to dash in Ubuntu and doesn't support
[[syntax.Fixes #3773