Resolve Makefile error on Ubuntu (#3780)

cs3org · Apr 11, 2023 · 909d369 · 909d369
1 parent 6f953ae
commit 909d369
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/Makefile b/Makefile
@@ -1,3 +1,6 @@
+# force makefile to use bash instead of sh.
+SHELL := /usr/bin/env bash
+
 .PHONY: all
 all: revad reva test-go lint gen-doc
 

diff --git a/changelog/unreleased/fix-makefile.md b/changelog/unreleased/fix-makefile.md
@@ -0,0 +1,7 @@
+Bugfix: Fix Makefile error on Ubuntu
+
+I've fixed Makefile using sh which is defaulted to dash in ubuntu, dash doesn't support
+`[[ ... ]]` syntax and Makefile would throw `/bin/sh: 1: [[: not found` errors.
+
+https://github.com/cs3org/reva/pull/3780
+https://github.com/cs3org/reva/issues/3773