Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile depends on bash #3773

Closed
michielbdejong opened this issue Apr 5, 2023 · 1 comment · Fixed by #3780
Closed

Makefile depends on bash #3773

michielbdejong opened this issue Apr 5, 2023 · 1 comment · Fixed by #3780

Comments

@michielbdejong
Copy link
Contributor

Since 0374913 it is no longer possible to build revad on Ubuntu, because it uses dash instead of bash as the shell, which doesn't support the [[ ... ]]] syntax.

@michielbdejong
Copy link
Contributor Author

A workaround is to remove that first term from the build flags, so it becomes:

BUILD_FLAGS    = " -X main.gitCommit=$(GIT_COMMIT) -X main.version=$(VERSION) -X main.goVersion=$(GO_VERSION) -X main.buildDate=$(BUILD_DATE)"

That is what we will be using on our server, because we're not using the static linking feature there anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant