This repository has been archived by the owner on Apr 3, 2020. It is now read-only.
Fix invalid native context reference in simd128-tag #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The solution is to inline the native context load. BUG=XWALK-2255 (cherry picked from commit 5aa07fb)
|
Cherry-pick from master to Crosswalk-8 branch. @darktears , PTAL. Thanks. |
|
LGTM |
darktears
added a commit
that referenced
this pull request
Aug 20, 2014
Fix invalid native context reference in simd128-tag
mrunalk
pushed a commit
that referenced
this pull request
May 13, 2016
mrunalk
pushed a commit
that referenced
this pull request
May 20, 2016
Merged 06c5127 [full-codegen] Introduce NestedStatement subclass for class literals. BUG=v8:4965 LOG=N R=hablich@chromium.org NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/1988713003 Cr-Commit-Position: refs/branch-heads/5.1@{#49} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
mrunalk
pushed a commit
that referenced
this pull request
Aug 1, 2016
Merged 1f53e42 Handle symbols in FrameMirror#invocationText(). R=yangguo@chromium.org, hablich@chromium.org BUG= Review URL: https://codereview.chromium.org/2159803002 . Cr-Commit-Position: refs/branch-heads/5.2@{#49} Cr-Branched-From: 2cd36d6-refs/heads/5.2.361@{#1} Cr-Branched-From: 3fef34e-refs/heads/master@{#36332}
mrunalk
pushed a commit
that referenced
this pull request
Sep 1, 2016
mrunalk
pushed a commit
that referenced
this pull request
Sep 27, 2016
Revision: ec9bfc8 BUG=v8:4561 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org Review URL: https://codereview.chromium.org/2346923002 . Cr-Commit-Position: refs/branch-heads/5.4@{#49} Cr-Branched-From: 5ce2827-refs/heads/5.4.500@{#2} Cr-Branched-From: ad07b49-refs/heads/master@{#38841}
imreotto
pushed a commit
to tenta-browser/v8-crosswalk
that referenced
this pull request
Sep 4, 2017
Revision: f82a59a BUG=chromium:714207 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=mlippautz@chromium.org Change-Id: Iae7b7032e1d72fe9574a61dc632d3411e1289109 Reviewed-on: https://chromium-review.googlesource.com/506072 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/branch-heads/5.9@{crosswalk-project#49} Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{crosswalk-project#1} Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
asifhisam
pushed a commit
to asifhisam/v8-crosswalk
that referenced
this pull request
Sep 9, 2019
Revision: c019e53 BUG=chromium:706642 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I61e9d2decb269b33aefcc6e77d6c09bab3a2a994 Reviewed-on: https://chromium-review.googlesource.com/465828 Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/branch-heads/5.8@{crosswalk-project#49} Cr-Branched-From: eda659c-refs/heads/5.8.283@{crosswalk-project#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The solution is to inline the native context load.
BUG=XWALK-2255
(cherry picked from commit 5aa07fb)