Fix time series executions view not updating #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time series executions view (when clicking on a specific interval of a specific job in the calendar focus view) queries an url to get the list of executions, and is supposed to use server sent events to auto refresh that list. However that url would simply serve the first snapshot and never refresh it, due to the snapshot being put in a pure IO after it has been computed. We just fix that by putting the actual computation of the snapshot in an IO, which will refresh the server sent events properly.
yetanotherion
approved these changes
Aug 31, 2020
yetanotherion
pushed a commit
to yetanotherion/cuttle
that referenced
this pull request
Aug 31, 2020
* Fix time series executions view not updating (criteo#562) * Cron context fixes (criteo#560)
Merged
yetanotherion
pushed a commit
that referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The time series executions view (when clicking on a specific interval of a specific job in the calendar focus view) queries an url to get the list of executions, and is supposed to use server sent events to auto refresh that list.
However that url would simply serve the first snapshot and never refresh it, due to the snapshot being put in a pure IO after it has been computed.
We just fix that by putting the actual computation of the snapshot in an IO, which will refresh the server sent events properly.