Cron context fixes #560
Merged
Cron context fixes #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add schema evolution to create a cron_contexts table containing the contexts and convert the old values to new values - This also fixes job retries ignoring the retry strategy due to retries having a different context from the original execution (as they contained the retry number)
dufrannea
approved these changes
Aug 27, 2020
yetanotherion
pushed a commit
to yetanotherion/cuttle
that referenced
this pull request
Aug 31, 2020
* Fix time series executions view not updating (criteo#562) * Cron context fixes (criteo#560)
Merged
yetanotherion
pushed a commit
that referenced
this pull request
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the Cron context to only contain instant and runNow user:
Also clean up some of the job <-> dag confusions in the code and rename Cron Dependency as (from, to) instead of (parent, child)