Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: guarantee that max prefix length is < min prefix length + child size #369

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

fix: guarantee that max prefix length is < min prefix length + child size #369

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac0743b
fix: guarantee that max prefix length is < min prefix length + child …
crodriguezvega Sep 10, 2024
3d7762d
same fix for rust implementation
crodriguezvega Sep 10, 2024
98f8721
add test for rust
crodriguezvega Sep 10, 2024
277f4f4
lint
crodriguezvega Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions go/ops.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,10 @@ func (op *InnerOp) CheckAgainstSpec(spec *ProofSpec, b int) error {
return errors.New("spec.InnerSpec.ChildSize must be >= 1")
}

if spec.InnerSpec.MaxPrefixLength >= spec.InnerSpec.MinPrefixLength+spec.InnerSpec.ChildSize {
return errors.New("spec.InnerSpec.MaxPrefixLength must be < spec.InnerSpec.MinPrefixLength + spec.InnerSpec.ChildSize")
}

// ensures soundness, with suffix having to be of correct length
if len(op.Suffix)%int(spec.InnerSpec.ChildSize) != 0 {
return fmt.Errorf("InnerOp suffix malformed")
Expand Down
28 changes: 25 additions & 3 deletions rust/src/verify.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,7 +203,11 @@
);
ensure!(
inner_spec.child_size > 0,
"spec.InnerSpec.ChildSize must be >= 1"
"spec.inner_spec.child_size must be >= 1"

Check warning on line 206 in rust/src/verify.rs

View check run for this annotation

Codecov / codecov/patch

rust/src/verify.rs#L206 

Added line #L206 was not covered by tests
);
ensure!(
inner_spec.max_prefix_length < inner_spec.min_prefix_length + inner_spec.child_size,
"spec.inner_spec.max_prefix_length must be < spec.inner_spec.min_prefix_length + spec.inner_spec.child_size"
);
ensure!(
inner.suffix.len() % (inner_spec.child_size as usize) == 0,
Expand Down Expand Up @@ -484,6 +488,11 @@
depth_limited_spec.min_depth = 2;
depth_limited_spec.max_depth = 4;


let mut max_prefix_length_too_large_spec = api::iavl_spec();
let inner_spec = max_prefix_length_too_large_spec.inner_spec.as_mut().unwrap();
inner_spec.max_prefix_length = 100;

let cases: HashMap<&'static str, ExistenceCase> = [
(
"empty proof fails",
Expand Down Expand Up @@ -612,19 +621,32 @@
proof: ExistenceProof {
key: b"foo".to_vec(),
value: b"bar".to_vec(),
leaf: Some(leaf),
leaf: Some(leaf.clone()),
path: vec![
valid_inner.clone(),
valid_inner.clone(),
valid_inner.clone(),
valid_inner.clone(),
valid_inner,
valid_inner.clone(),
],
},
spec: depth_limited_spec,
valid: false,
},
),
(
"rejects inner spec with max prefix length >= min prefix lenght + child size",
ExistenceCase {
proof: ExistenceProof {
key: b"foo".to_vec(),
value: b"bar".to_vec(),
leaf: Some(leaf),
path: vec![valid_inner],
},
spec: max_prefix_length_too_large_spec,
valid: false,
},
),
]
.into_iter()
.collect();
Expand Down
Loading