Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guarantee that max prefix length is < min prefix length + child size #369

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

crodriguezvega
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.74%. Comparing base (a72a6cb) to head (98f8721).

Files with missing lines Patch % Lines
rust/src/verify.rs 95.83% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #369      +/-   ##
==========================================
+ Coverage   67.51%   67.74%   +0.22%     
==========================================
  Files           7        7              
  Lines        3014     3035      +21     
==========================================
+ Hits         2035     2056      +21     
  Misses        979      979              
Flag Coverage Δ
rust 67.74% <95.83%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AdityaSripal AdityaSripal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Ideally we would also have a test that malleates the prefix in order to fool the proof system that now fails. You should be able to pull out the test case from the audit report so don't have to create yourself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants