Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make host_timestamp() abstract #457

Merged
merged 3 commits into from
Feb 21, 2023
Merged

Make host_timestamp() abstract #457

merged 3 commits into from
Feb 21, 2023

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Feb 21, 2023

Closes: #418


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 60.03% // Head: 60.06% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (34db1cf) compared to base (e02d38c).
Patch has no changes to coverable lines.

❗ Current head 34db1cf differs from pull request most recent head 07f61e8. Consider uploading reports for the commit 07f61e8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   60.03%   60.06%   +0.02%     
==========================================
  Files         131      131              
  Lines       18810    18801       -9     
==========================================
  Hits        11292    11292              
+ Misses       7518     7509       -9     
Impacted Files Coverage Δ
crates/ibc/src/core/context.rs 84.34% <ø> (+2.48%) ⬆️
crates/ibc/src/mock/context.rs 68.66% <ø> (+0.15%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@Farhad-Shabani Farhad-Shabani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the changelog comment. LGTM. Thank you 🙏

.changelog/unreleased/improvement/418-host-timestamp.md Outdated Show resolved Hide resolved
@plafer plafer merged commit 317770c into main Feb 21, 2023
@plafer plafer deleted the plafer/418-host-timestamp branch February 21, 2023 19:48
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Feb 24, 2023
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* make host_timestamp abstract

* changelog

* changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: breaking Admin: breaking change that may impact operators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ValidationContext::host_timestamp() should be made abstract
2 participants