Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ValidationContext::host_timestamp() should be made abstract #418

Closed
plafer opened this issue Feb 10, 2023 · 1 comment · Fixed by #457
Closed

ValidationContext::host_timestamp() should be made abstract #418

plafer opened this issue Feb 10, 2023 · 1 comment · Fixed by #457
Labels
A: breaking Admin: breaking change that may impact operators A: good-first-issue Admin: good for newcomers O: security Objective: aims to enhance security and improve safety
Milestone
v0.29.0

Comments

@plafer
Copy link
Contributor

plafer commented Feb 10, 2023

here. Was copy-pasted from ClientReader.
@plafer plafer added the O: security Objective: aims to enhance security and improve safety label Feb 10, 2023
@plafer plafer added this to the v0.29.0 milestone Feb 10, 2023
@plafer plafer added the A: good-first-issue Admin: good for newcomers label Feb 10, 2023
@plafer
Copy link
Contributor Author

plafer commented Feb 10, 2023

After more digging, host_timestamp() should be made abstract, and pending_host_consensus_state() should be removed.

host_timestamp() is re-implemented in our MockContext, as well as in basecoin-rs. pending_host_consensus_state() was only used inside our unused (and dangerous) default implementation.

@Farhad-Shabani Farhad-Shabani mentioned this issue Feb 14, 2023
Closed
7 tasks
@plafer plafer mentioned this issue Feb 21, 2023
Merged
7 tasks
@plafer plafer changed the title ValidationContext::host_timestamp() should not expect() ValidationContext::host_timestamp() should be made abstract Feb 22, 2023
@Farhad-Shabani Farhad-Shabani added the A: breaking Admin: breaking change that may impact operators label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: breaking Admin: breaking change that may impact operators A: good-first-issue Admin: good for newcomers O: security Objective: aims to enhance security and improve safety
Projects
ibc-rs
Status: ✅ Done
Milestone
v0.29.0
Development

Successfully merging a pull request may close this issue.

Make host_timestamp() abstract cosmos/ibc-rs
2 participants
@plafer @Farhad-Shabani