fix(ibc): add missing dependencies for feature flags across multiple crates #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1060 +/- ##
=======================================
Coverage 67.05% 67.05%
=======================================
Files 204 204
Lines 20552 20552
=======================================
Hits 13782 13782
Misses 6770 6770 ☔ View full report in Codecov by Sentry. |
rnbguy
reviewed
Jan 26, 2024
Comment on lines
+94
to
95
| #[cfg(feature = "serde")] | ||
| impl FromStr for Ics721Data { |
There was a problem hiding this comment.
I find this interesting as this general FromStr trait is only implemented with serde. I would expect this to be implemented with borsh or any other similar features - or is this necessary?
Farhad-Shabani
added a commit
that referenced
this pull request
Sep 9, 2024
…crates (#1060) * fix: add missing dependencies for some feature flags * fix: derive serde attr on ics20 serializer imports * ease serde derive on ICS20 & ICS721 types * imp: ease serde derive on ics20 and ics721 types * nit: fix the name of v0.50.0 dir under changelog * nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1059
Integration tests: informalsystems/basecoin-rs#151
Remark
Along with this PR:
serdederive on ICS-20 and ICS-721 domain typesv0.50.0directory under the changelogPR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.