Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing some dependency inclusion for feature flags #1059

Closed
Farhad-Shabani opened this issue Jan 25, 2024 · 2 comments · Fixed by #1060
Closed

Missing some dependency inclusion for feature flags #1059

Farhad-Shabani opened this issue Jan 25, 2024 · 2 comments · Fixed by #1060
Assignees
Labels
A: bug Admin: something isn't working
Milestone

Comments

@Farhad-Shabani
Copy link
Member

Summary

Encountered an issue where essential dependencies for some feature flags were missing in several crates, notably within the ibc-core. Surprisingly, the cargo hack tool failed to detect these missing dependencies. It sounds like it struggles to accurately assess feature combinations in cases involving multiple layers of crates stacked on top of each other.

Version

=< 0.50.0

@romac
Copy link
Member

romac commented Jan 25, 2024

Maybe give https://crates.io/crates/cargo-hakari a try and see if it works better than cargo-hack?

@Farhad-Shabani
Copy link
Member Author

Maybe give https://crates.io/crates/cargo-hakari a try and see if it works better than cargo-hack?

Appreciate the tip @romac ! I gave cargo hakari a try, but it didn't catch the missing dependency either. I even tried running cargo check locally with a different set of features, but no luck catching those corner scenarios. Right now, I'm just fixing things manually and sticking with the cargo hack since it does catch a bunch of cases.

@Farhad-Shabani Farhad-Shabani added this to the 0.51.0 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: bug Admin: something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants