Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipes for pyro-api and pyro-ppl #14161

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

jamestwebber
Copy link
Contributor

@jamestwebber jamestwebber commented Mar 4, 2021

Submitting recipes to add Pyro to conda-forge, which will make life easier for some downstream projects. There are two recipes: pyro-ppl is the main package while pyro-api is a base package used to share common code with other projects.

Both are pure Python* so I included noarch: python in the recipes.

* pyro-ppl technically contains C++ but it is imported at runtime by PyTorch rather than compiled on installation.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged. N/A
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pyro-api, recipes/pyro-ppl) and found it was in an excellent condition.

@jamestwebber
Copy link
Contributor Author

@conda-forge-admin, please ping team

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

@jamestwebber
Copy link
Contributor Author

One note that I don't know how to fix: the proper/supported source for pytorch is from their channel (e.g. conda install pytorch -c pytorch). That might be why the windows build is failing?

@jamestwebber
Copy link
Contributor Author

pytorch just released a new version (1.8.0) and pyro tries to match releases, so they released as well (1.6.0).

I was able to build the new release locally, but the conda-forge channel doesn't have pytorch 1.8.0 yet so I didn't push the changes here.

Also, I looked at the windows errors and I have no idea what it's complaining about. It seems to have some issue in the dependency solver but I don't know what it is.

@chrisburr
Copy link
Member

Yeah, apparently we're missing pytorch builds for Windows: conda-forge/pytorch-cpu-feedstock#32

As this is noarch: python it doesn't matter as we'll only build on Linux in the feedstock.

@chrisburr chrisburr merged commit 0513212 into conda-forge:master Mar 5, 2021
@jamestwebber jamestwebber deleted the pyro-ppl branch March 5, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants