-
-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyro-ppl to conda-forge #1764
Comments
This seems like unnecessary overhead. We have limited resources on the Pyro team, and I feel those resources are better spent on documentation, design, and support. Also this would add extra friction to the already high-friction release process, and in response we would react by releasing less frequently. |
I guess this just adds a tiny overhead because all we will do is to press a merge button when receives a notification from conda-forge. But I'll test how it will go first. |
@fehiepsi The kind of overhead I'm talking about is developer resources, where we will inevitably break something in the conda configuration and then some developer will have to spend hours debugging and fixing it, and ask another developer to help out with another few hours. Unless there is significant user demand for conda packages, our precious developer time is better spend elsewhere. |
I'm workin' on it! Using guides from conda and conda-forge. Small-ish hiccups encountered so far (recording for posterity):
Other than that things look to be working, at least on my machine. I believe the next step is to create a PR to https://github.com/conda-forge/staged-recipes |
Oh, also created pyro-ppl/pyro-api#21 so that the license file is included for that package. For now, I can include it in the recipe itself. |
Does everyone agree if I submit a PR to add pyro-ppl to conda-forge with the receipt?
About maintaining, whenever we have a new version, conda-forge will automatically make a PR with updated version and updated sha256. The only thing we need to do is merging that PR if everything is fine. If we change requirements in future versions, we will need to submit a PR to change the requirements section of that recipe.
If everyone is fine with it, then there are two things we'll need to change:
The text was updated successfully, but these errors were encountered: