Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miniscript: add version 1.6.2 #22861
base: master
Are you sure you want to change the base?
miniscript: add version 1.6.2 #22861
Changes from all commits
8a9e9a2
ed8a2ff
f821445
c4ef4ef
b5924de
4ec4f30
67174d5
37a47c4
e8cf7b6
bbc9ebc
a573187
697091d
6b5baf1
1a58545
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not enforce shared libraries in Windows. Instead, I would recommend asking support from the upstream directly. Remember that
CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
really fragile, it not only exposes all symbols, including those that should be private, but also lacks exposing public static variables, which causes runtime errors when being consumed (e.g. libcoro).