Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miniscript: add version 1.6.2 #22861

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

toge
Copy link
Contributor

@toge toge commented Feb 22, 2024

Specify library name and version: miniscript/1.6.2

  • follow library names in 1.5.1
  • use upstream CMakeLists.tt in 1.6.2
  • follow API changes since 1.6.2

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@AbrilRBS AbrilRBS self-assigned this Feb 26, 2024
@AbrilRBS
Copy link
Member

Dum dum CI did not post the results, sorry about that. Restarting v1, but v2 failed https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/22861/6-windows-msvc/miniscript/1.5.1//summary.json for a proper reason

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@uilianries
Copy link
Member

Hello @toge The version 1.6.2 has a CMakeLists.txt supported: https://github.com/JoeStrout/miniscript/blob/v1.6.2/CMakeLists.txt

Is is not enough to build the project?

@toge
Copy link
Contributor Author

toge commented Mar 4, 2024

@uilianries
Hello uilianries.
Thanks you for your review.

I know that.
If version is 1.6.2, this recipe tries to use CMakeLists.txt from upstream.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

perseoGI
perseoGI previously approved these changes Jul 29, 2024
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (1a58545490a5946685cf09f9bc09afa95800f21b):

  • miniscript/1.5.1:
    All packages built successfully! (All logs)

  • miniscript/1.6.2:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (1a58545490a5946685cf09f9bc09afa95800f21b):

  • miniscript/1.5.1:
    All packages built successfully! (All logs)

  • miniscript/1.6.2:
    All packages built successfully! (All logs)

Comment on lines +81 to +84
if Version(self.version) >= "1.6.2":
tc.variables["CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS"] = True
else:
tc.variables["MINISCRIPT_SRC_DIR"] = self.source_folder.replace("\\", "/")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if Version(self.version) >= "1.6.2":
tc.variables["CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS"] = True
else:
tc.variables["MINISCRIPT_SRC_DIR"] = self.source_folder.replace("\\", "/")
if Version(self.version) < "1.6.2":
tc.variables["MINISCRIPT_SRC_DIR"] = self.source_folder.replace("\\", "/")

I would not enforce shared libraries in Windows. Instead, I would recommend asking support from the upstream directly. Remember that CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS really fragile, it not only exposes all symbols, including those that should be private, but also lacks exposing public static variables, which causes runtime errors when being consumed (e.g. libcoro).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants