-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
miniscript: add version 1.6.2 #22861
base: master
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dum dum CI did not post the results, sorry about that. Restarting v1, but v2 failed https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/22861/6-windows-msvc/miniscript/1.5.1//summary.json for a proper reason |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Hello @toge The version 1.6.2 has a CMakeLists.txt supported: https://github.com/JoeStrout/miniscript/blob/v1.6.2/CMakeLists.txt Is is not enough to build the project? |
@uilianries I know that. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Conan v1 pipeline ✔️All green in build 4 (
Conan v2 pipeline ✔️
All green in build 4 ( |
if Version(self.version) >= "1.6.2": | ||
tc.variables["CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS"] = True | ||
else: | ||
tc.variables["MINISCRIPT_SRC_DIR"] = self.source_folder.replace("\\", "/") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if Version(self.version) >= "1.6.2": | |
tc.variables["CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS"] = True | |
else: | |
tc.variables["MINISCRIPT_SRC_DIR"] = self.source_folder.replace("\\", "/") | |
if Version(self.version) < "1.6.2": | |
tc.variables["MINISCRIPT_SRC_DIR"] = self.source_folder.replace("\\", "/") |
I would not enforce shared libraries in Windows. Instead, I would recommend asking support from the upstream directly. Remember that CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS
really fragile, it not only exposes all symbols, including those that should be private, but also lacks exposing public static variables, which causes runtime errors when being consumed (e.g. libcoro).
Specify library name and version: miniscript/1.6.2