Load js asynchronously and login using url #60
Conversation
README.md
Outdated
| @@ -73,50 +73,32 @@ To test against a local hydra instance | |||
| ### Make your frontend editable | |||
|
|
|||
| - Take the latest [hydra.js](https://github.com/collective/volto-hydra/tree/hydra.js) and include it in your frontend | |||
There was a problem hiding this comment.
this is repeated below. don't need both
There was a problem hiding this comment.
we didn't mentioned about including hydra.js in below sections?
There was a problem hiding this comment.
@MAX-786 This will need updating to use the @volto-hydra/hydra-js package now
There was a problem hiding this comment.
this means directing them to packages/hydra-js , right? as this package is not made available they can't import it in their frontend.
# Conflicts: # packages/hydra-js/hydra.js # packages/volto-hydra/src/components/Iframe/View.jsx
|
@MAX-786 I've merged main into this branch. Could you make sure this all still works as you intended before I review it? |
|
@JeffersonBledsoe I was fixing conflicts on local, THANKS for doing it . I'll just give it a final check. |
|
@JeffersonBledsoe LGTM! all features expect select block works fine |
|
Can we First merge this on main, so then I'll pull these changes to Select Block PR. Which will resolve your commented out changes there |
|
@djay Can you check the docs again on this and I'll peak at the code? |
Fixes #47
This also fixes slow loading of iframe by cleaning up residue events which are being accumulated.