Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an integrator I can not have to load hydra.js all the time to know user has started editing #47

Closed
2 tasks
Tracked by #6
djay opened this issue Jun 12, 2024 · 4 comments · Fixed by #60
Closed
2 tasks
Tracked by #6

Comments

@djay
Copy link
Member

djay commented Jun 12, 2024

This means anon browsing is kept lean by not loading things they don't have to

  • use a url argument to signify the frontend can load hydra.js and init the bridge
  • simplify the readme and explain once how to init the bridge and use the token
@djay
Copy link
Member Author

djay commented Jun 18, 2024

@MAX-786 I think it would be good to do this now since the current README is very hard to understand. it says how to init three times and its much harder to understand that you get the token after you init rather than before.

@djay
Copy link
Member Author

djay commented Jun 19, 2024

Currently auth is broken. so switching to this should fix that problem

@JeffersonBledsoe
Copy link
Member

@MAX-786 Just a heads up, the query parameter should be named 'access_token' as it follows the auth pattern defined in https://www.rfc-editor.org/rfc/rfc6750#section-2.3 . No direct benefit to us as we aren't using the token directly for requesting resources in the admin UI, but it makes things clearer for the integrator.

@MAX-786
Copy link
Member

MAX-786 commented Jun 19, 2024

Ooh I used as 'auth_token' same as it is stored in cookies... good thing I havent pushed that commit in remote :)
I will change it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants