Issue 27 #565
Merged
Issue 27 #565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check that event is included in parsing
…components as equal to the bigger component
Add documentation about parsing
updated about.rst to include details that the repo is not obsolete and still compliant with RFC5545
Exposed by running in `python3 -b` mode.
Fix `vText.__repr__` `BytesWarning`
version 5.0.8
The time zone was missing from PERIOD values. See niccokunzmann/python-recurring-ical-events#113
Add timezone to period value types
version 5.0.9
- did not reference self at all - keeps compatibility with existing code - makes testing easier Signed-off-by: Felix Stupp <felix.stupp@banananet.work>
Signed-off-by: Felix Stupp <felix.stupp@banananet.work>
Signed-off-by: Felix Stupp <felix.stupp@banananet.work>
Signed-off-by: Felix Stupp <felix.stupp@banananet.work>
Component._encode: merge instead of ignore parameters on natives
version 5.0.10
Previously the start and end datetimes were always printed out in the timezone that they appear in the calendar entry. In 7a8d584 duration support was added and an attempt was already made to display the datetime in the local timezone. Unfortunately in that specific case the `start.astimezone(start.tzinfo)` is a no-op and does absolutely nothing. Unlike the name suggests, `astimezone()` adjusts the date and time data, such that they match the passed tzinfo, but since that is the same timezone data as before, nothing changes. [0] In order to properly convert to the user's local timezone, we need to call the method with no arguments. With this the timezone is always properly displayed, which makes up for a much nicer UX for users of the cli. The test has to be adapted to expect the datetime in the local timezone, hence we cannot hardcode the entire expected string anymore. [0] https://docs.python.org/3/library/datetime.html#datetime.datetime.astimezone
|
Hm. Somehow, I do not really know what has changed... I will have a look..... |
niccokunzmann
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.