Fix vText.__repr__ BytesWarning

[scop]

Exposed by running in python3 -b mode.

[scop]

The !r approach preserves existing behavior. Depending on desired outcome, another fix would be

Suggested change

	return f"vText('{self.to_ical()!r}')"
	return f"vText('{self.to_ical().decode(self.encoding)}')"

[jacadzaca]

I like the decode version better

[jacadzaca]

hey, big thanks for the PR! Since the ical text is stored as bytes internally, I think having bytes explicitly in __repr__ is correct behavior. However, I think your suggestion would be an ideal implementation of an __str__ :) What do you think?

A __str__ / __repr__ implementation for other v elements would also be very welcome, since they all are lacking one :)

Also, please fill out the CHANGELOG and add yourself to CREDITS as per CONTRIBUTING

[scop]

Since the ical text is stored as bytes internally, I think having bytes explicitly in __repr__ is correct behavior.

Agree, that's (and for no behavioral changes) why I opted for the !r option.

However, I think your suggestion would be an ideal implementation of an __str__ :) What do you think?

Kind of, but then again I don't know if the vText('...') "wrapper" belongs in it. Anyway, I'd like to leave that and addition of any additional __str__/__repr__ implementations out from this PR to keep it in scope. And frankly, leave all that to someone else to take care of :)

Also, please fill out the CHANGELOG and add yourself to CREDITS

Done.

[jacadzaca]

Thanks for the PR :)

[niccokunzmann]

This is part of release 5.0.8