Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Field validation #40

Draft
wants to merge 60 commits into
base: main
Choose a base branch
from
Draft

WIP: Field validation #40

wants to merge 60 commits into from

Commits on Sep 22, 2023

  1. Add class for 'Fields' to simplify custom logic and use it for filter… 

    …_parameters
    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 22, 2023
    Configuration menu
    Copy the full SHA
    c458ee2 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2023

  1. Fix non-required fields

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    d6aa386 View commit details
    Browse the repository at this point in the history

  2. Fix reading incorrect internal value

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    17697d8 View commit details
    Browse the repository at this point in the history

  3. Fix values not displayign

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    b9bb05f View commit details
    Browse the repository at this point in the history

  4. Use @Property for 'value'

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 24, 2023
    Configuration menu
    Copy the full SHA
    3c45a3a View commit details
    Browse the repository at this point in the history

Commits on Sep 25, 2023

  1. Fix some existing behaviours

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    70a17f1 View commit details
    Browse the repository at this point in the history

  2. Add test for custom_field_id

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    9bf7879 View commit details
    Browse the repository at this point in the history

  3. Fix custom field ID

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    624170d View commit details
    Browse the repository at this point in the history

  4. Fix inconsistent use of field_id in requess

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    3ea20ae View commit details
    Browse the repository at this point in the history

  5. Restore support for falling back to field_id if label doesn't exist

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    b3ca7da View commit details
    Browse the repository at this point in the history

  6. Fix data storing

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    e821e3f View commit details
    Browse the repository at this point in the history

  7. Fix custom_field_id in data export

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    cd8e9bb View commit details
    Browse the repository at this point in the history

  8. Merge branch 'main' into custom-label-mapping

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 25, 2023
    Configuration menu
    Copy the full SHA
    bd40e5c View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. Add tests for display values

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    e1994e0 View commit details
    Browse the repository at this point in the history

  2. Fix catalog using display value for storage

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    b5c75da View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2023

  1. Fix XML using external value

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    f2ff588 View commit details
    Browse the repository at this point in the history

  2. Update frontend field name

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    2cf29d3 View commit details
    Browse the repository at this point in the history

  3. Test fix

    @JeffersonBledsoe
    JeffersonBledsoe committed Sep 27, 2023
    Configuration menu
    Copy the full SHA
    810d675 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2023

  1. Initial validation support

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    9a76a5c View commit details
    Browse the repository at this point in the history

  2. Fix HTTP response code

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    c184b55 View commit details
    Browse the repository at this point in the history

  3. Fix crash when no validations are set

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    bd1e2d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. Readme

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    5524684 View commit details
    Browse the repository at this point in the history

  2. Typo fix

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 15, 2023
    Configuration menu
    Copy the full SHA
    ac749fb View commit details
    Browse the repository at this point in the history

Commits on Dec 19, 2023

  1. Initial serializer for validation settings

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 19, 2023
    Configuration menu
    Copy the full SHA
    8df42f5 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2023

  1. Add "ignore" to list of internal ignored fields

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    94cd023 View commit details
    Browse the repository at this point in the history

  2. Fix serializer deleting the actual validation object's settings

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 20, 2023
    Configuration menu
    Copy the full SHA
    97b1815 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2023

  1. Fix IPloneSiteRoot import

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 21, 2023
    Configuration menu
    Copy the full SHA
    ff79791 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2023

  1. Fix validations not occurign

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    2dcd6fb View commit details
    Browse the repository at this point in the history

  2. Able to return nice error messages

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    afc6b7d View commit details
    Browse the repository at this point in the history

  3. WIP: Custom validation

    @JeffersonBledsoe
    JeffersonBledsoe committed Dec 22, 2023
    Configuration menu
    Copy the full SHA
    83ad017 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2024

  1. Merge branch 'main' into custom-label-mapping 

    # Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 8, 2024
    Configuration menu
    Copy the full SHA
    262fce7 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2024

  1. Add test for custom field ID and ensuring it isn't used in emails

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    30adf28 View commit details
    Browse the repository at this point in the history

  2. Fix using field_id in XML

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    47ede0b View commit details
    Browse the repository at this point in the history

  3. Remove upgrades and test files from coverage

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    3785922 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2024

  1. Improve tests for sending and storing custom fields

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    adb24a4 View commit details
    Browse the repository at this point in the history

  2. Fix for storing CSVs

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 11, 2024
    Configuration menu
    Copy the full SHA
    c778d90 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2024

  1. Merge branch 'custom-label-mapping' into field-validation 

    # Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/field.py
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    1f301f7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into field-validation

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 12, 2024
    Configuration menu
    Copy the full SHA
    a109261 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Quick messy test for validation

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    b4ac3e1 View commit details
    Browse the repository at this point in the history

  2. Fix settings saving (still need to get the correct type information f… 

    …or the settings)
    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    6606bc1 View commit details
    Browse the repository at this point in the history

Commits on Jan 17, 2024

  1. Overhaul how we're passing settings back and forth

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    731d331 View commit details
    Browse the repository at this point in the history

  2. Fix setting deserialization after overhall

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    70d9aaf View commit details
    Browse the repository at this point in the history

  3. Fix settings not being passed to validators

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    bec2107 View commit details
    Browse the repository at this point in the history

  4. Fix bad settings appearing in UI

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 17, 2024
    Configuration menu
    Copy the full SHA
    61b020a View commit details
    Browse the repository at this point in the history

Commits on Jan 18, 2024

  1. Fix crash on serializing existing fields

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    2899a93 View commit details
    Browse the repository at this point in the history

  2. Fix type of validations

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    e98dd67 View commit details
    Browse the repository at this point in the history

  3. Fix characters validation behaviour

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    ac67bdd View commit details
    Browse the repository at this point in the history

  4. Fix bad attribute

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    38e9f9b View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2024

  1. Fix passing type information to the frontend and reduce some complexi… 

    …ty in the submission flow
    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    0251d4b View commit details
    Browse the repository at this point in the history

  2. Remove validations and settings if the field type doesn't allow for v… 

    …alidations
    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 26, 2024
    Configuration menu
    Copy the full SHA
    41a7cda View commit details
    Browse the repository at this point in the history

Commits on Jan 29, 2024

  1. Don't include inNumericRange as the code isn't great currently

    @JeffersonBledsoe
    JeffersonBledsoe committed Jan 29, 2024
    Configuration menu
    Copy the full SHA
    d54879d View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. Fix exceptions for existing forms

    @JeffersonBledsoe
    JeffersonBledsoe committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    7178369 View commit details
    Browse the repository at this point in the history

  2. Temp test fix

    @JeffersonBledsoe
    JeffersonBledsoe committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    b35cb89 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. Don't validate if the field shouldn't be shown

    @JeffersonBledsoe
    JeffersonBledsoe committed Mar 12, 2024
    Configuration menu
    Copy the full SHA
    caebd31 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2024

  1. Fix for validations without settings save

    @JeffersonBledsoe
    JeffersonBledsoe committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    77bd00b View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Skip validating non-required fields

    @JeffersonBledsoe
    JeffersonBledsoe committed Mar 19, 2024
    Configuration menu
    Copy the full SHA
    30a619d View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Fix bad breakpoint... whoops!

    @JeffersonBledsoe
    JeffersonBledsoe committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    976e0f0 View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2024

  1. Server-validate required field

    @JeffersonBledsoe
    JeffersonBledsoe committed Apr 2, 2024
    Configuration menu
    Copy the full SHA
    d5e052f View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2024

  1. Fix hidden fields sometimes validating when they are hidden

    @JeffersonBledsoe
    JeffersonBledsoe committed Apr 8, 2024
    Configuration menu
    Copy the full SHA
    3251e4f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Number of words validator

    @JeffersonBledsoe
    JeffersonBledsoe committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    7df5dda View commit details
    Browse the repository at this point in the history