Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Field validation #40

Draft
wants to merge 60 commits into
base: main
Choose a base branch
from
Draft

WIP: Field validation #40

wants to merge 60 commits into from

Conversation

JeffersonBledsoe
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe commented Dec 12, 2023 •
edited
Loading

This PR builds upon #37 To add support for validating fields. An optional install for Products.validation is added and the validators in here can be used to validate a field from a submission

Todo

  • Add some additional validators not found in Products.validation, such as "min length" and "max length" to cover existing validations that are covered by volto-form-block
  • Fix saving of settings. The deserializer for the frontend works well, but we need a serializer to convert back to something the validation objects support and update the objects themselves.
  • Tests

@JeffersonBledsoe
Add class for 'Fields' to simplify custom logic and use it for filter…
c458ee2 
…_parameters
@JeffersonBledsoe
Fix non-required fields
d6aa386
@JeffersonBledsoe
Fix reading incorrect internal value
17697d8
@JeffersonBledsoe
Fix values not displayign
b9bb05f
@JeffersonBledsoe
Use @Property for 'value'
3c45a3a
@JeffersonBledsoe
Fix some existing behaviours
70a17f1
@JeffersonBledsoe
Add test for custom_field_id
9bf7879
@JeffersonBledsoe
Fix custom field ID
624170d
@JeffersonBledsoe
Fix inconsistent use of field_id in requess
3ea20ae
@JeffersonBledsoe
Restore support for falling back to field_id if label doesn't exist
b3ca7da
@JeffersonBledsoe
Fix data storing
e821e3f
@JeffersonBledsoe
Fix custom_field_id in data export
cd8e9bb
@JeffersonBledsoe
Merge branch 'main' into custom-label-mapping
bd40e5c
@JeffersonBledsoe
Add tests for display values
e1994e0
@JeffersonBledsoe
Fix catalog using display value for storage
b5c75da
@JeffersonBledsoe
Fix XML using external value
f2ff588
@JeffersonBledsoe
Update frontend field name
2cf29d3
@JeffersonBledsoe
Test fix
810d675
@JeffersonBledsoe
Initial validation support
9a76a5c
@JeffersonBledsoe
Fix HTTP response code
c184b55
@JeffersonBledsoe
Fix crash when no validations are set
bd1e2d0
@JeffersonBledsoe
Readme
5524684
@JeffersonBledsoe
Typo fix
ac749fb
@JeffersonBledsoe
Initial serializer for validation settings
8df42f5
@JeffersonBledsoe
Add "ignore" to list of internal ignored fields
94cd023
@JeffersonBledsoe
Fix serializer deleting the actual validation object's settings
97b1815
@JeffersonBledsoe
Fix IPloneSiteRoot import
ff79791
@JeffersonBledsoe
Fix validations not occurign
2dcd6fb
@JeffersonBledsoe
Able to return nice error messages
afc6b7d
@JeffersonBledsoe
WIP: Custom validation
83ad017
@JeffersonBledsoe JeffersonBledsoe marked this pull request as draft January 10, 2024 09:38
@JeffersonBledsoe
Improve tests for sending and storing custom fields
adb24a4
@JeffersonBledsoe
Fix for storing CSVs
c778d90
@JeffersonBledsoe
Merge branch 'custom-label-mapping' into field-validation
1f301f7 
# Conflicts:
#	src/collective/volto/formsupport/restapi/services/submit_form/field.py
#	src/collective/volto/formsupport/restapi/services/submit_form/post.py
@JeffersonBledsoe
Merge branch 'main' into field-validation
a109261
@JeffersonBledsoe
Quick messy test for validation
b4ac3e1
@JeffersonBledsoe
Fix settings saving (still need to get the correct type information f…
6606bc1 
…or the settings)
@JeffersonBledsoe
Overhaul how we're passing settings back and forth
731d331
@JeffersonBledsoe
Fix setting deserialization after overhall
70d9aaf
@JeffersonBledsoe
Fix settings not being passed to validators
bec2107
@JeffersonBledsoe
Fix bad settings appearing in UI
61b020a
@JeffersonBledsoe
Fix crash on serializing existing fields
2899a93
@JeffersonBledsoe
Fix type of validations
e98dd67
@JeffersonBledsoe
Fix characters validation behaviour
ac67bdd
@JeffersonBledsoe
Fix bad attribute
38e9f9b
@JeffersonBledsoe
Fix passing type information to the frontend and reduce some complexi…
0251d4b 
…ty in the submission flow
@JeffersonBledsoe
Remove validations and settings if the field type doesn't allow for v…
41a7cda 
…alidations
@JeffersonBledsoe
Don't include inNumericRange as the code isn't great currently
d54879d
@JeffersonBledsoe
Fix exceptions for existing forms
7178369
@JeffersonBledsoe
Temp test fix
b35cb89
@JeffersonBledsoe
Don't validate if the field shouldn't be shown
caebd31
@JeffersonBledsoe
Fix for validations without settings save
77bd00b
@JeffersonBledsoe
Skip validating non-required fields
30a619d
@JeffersonBledsoe JeffersonBledsoe mentioned this pull request Mar 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@JeffersonBledsoe