Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Register viewlet only when the product is installed #70

Merged
merged 2 commits into from
Oct 1, 2018
Merged

Register viewlet only when the product is installed #70

merged 2 commits into from
Oct 1, 2018

Conversation

erral
Copy link
Member

@erral erral commented Oct 1, 2018

This fixes #69

hvelarde
hvelarde reviewed Oct 1, 2018
View reviewed changes
Copy link
Member

@hvelarde hvelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you won by a few seconds :) do you mind to update the changelog entry? use the text I used in #71.

@hvelarde hvelarde mentioned this pull request Oct 1, 2018
Closed
@hvelarde
Fix changelog
004a147 
[skip ci]
@hvelarde hvelarde merged commit f21ccdb into master Oct 1, 2018
@hvelarde hvelarde deleted the issue-69-fix-viewlet-registration branch October 1, 2018 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvelarde hvelarde hvelarde left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem with cache
2 participants
@erral @hvelarde