Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with cache #69

Closed
idgserpro opened this issue Oct 1, 2018 · 4 comments · Fixed by #70
Closed

Problem with cache #69

idgserpro opened this issue Oct 1, 2018 · 4 comments · Fixed by #70
Assignees
Labels

Comments

@idgserpro
Copy link
Member

idgserpro commented Oct 1, 2018

I added the collective.lazysizes in the eggs of a portal that has cache (Varnish).

When I accessed the portal before installing the product, Plone couldn't find the file ++resource ++collective.lazysizes /lazysizes-43c36fc.js, because the resources directory is only available after installation.

This is because the viewlet that attempts to access the js is available before the product is installed.

At this point, Varnish places the js in cache forever as not found. Since the file isn't in the portal_javascript, even after installing the product, Varnish continues to return the file as not found.

@erral
Copy link
Member

erral commented Oct 1, 2018

The solution will be to add the "layer" parameter in the ZCML registration here:

@idgserpro
Copy link
Member Author

@hvelarde @rodfersou

Please ensure that this problem doesn't occur in other packages that use webpack.

@hvelarde
Copy link
Member

hvelarde commented Oct 1, 2018

@idgserpro we're doing the best we can; I would appreciate code reviews instead of complaints.

@hvelarde
Copy link
Member

hvelarde commented Oct 1, 2018

@idgserpro I have released https://pypi.org/project/collective.lazysizes/4.1.2/ that should fix the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants