Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validation and defaults for fields in fieldsets. #177

Merged
merged 3 commits into from
Aug 11, 2019
Merged

Fix validation and defaults for fields in fieldsets. #177

merged 3 commits into from
Aug 11, 2019

Conversation

mauritsvanrees
Copy link
Member

This fixes #172 and #157 and probably #132 as well.
The validation fixes are forward ported from branch 1.x (PR #174).
The fixes for the default value are new, and the tests are new too.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 89.194% when pulling 1022c72 on maurits-issue-172-master into 1efc2f2 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 89.194% when pulling 1022c72 on maurits-issue-172-master into 1efc2f2 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 89.194% when pulling 1022c72 on maurits-issue-172-master into 1efc2f2 on master.

fredvd
fredvd approved these changes Aug 11, 2019
View reviewed changes
Copy link
Member

@fredvd fredvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We have the same fix already in production for a while on Plone 4 with the 1.X branch where we found the same issue.

@fredvd fredvd merged commit 1b10246 into master Aug 11, 2019
@mauritsvanrees mauritsvanrees mentioned this pull request Aug 30, 2019
Merged
@fredvd fredvd mentioned this pull request Sep 26, 2019
Merged
@fredvd fredvd deleted the maurits-issue-172-master branch November 8, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredvd fredvd fredvd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

isValidEmail validator doesn't work if field is outside default fieldset
3 participants
@mauritsvanrees @coveralls @fredvd