isValidEmail validator doesn't work if field is outside default fieldset

[fredvd]

The isvalidEmail validator doesn't work if you put in on a required field that is outside the default fieldset. Tested in easyform 1.x branch on Plone4 and easyform 2.1.0 on Plone 5.

Maybe also related to #157 where the defaut expression no longer works if the field is in a fieldset. Some actions are not run on fields in fieldsets. Also #132 relates to things not working in a fieldset

[fredvd]

Pfew, that was a debug session for me. Found it, I think:

collective.easyform/src/collective/easyform/fields.py

Lines 27 to 53 in 1efc2f2

	@implementer(IValidator)
	@adapter(IEasyForm, Interface, IEasyFormForm, IField, Interface)
	class FieldExtenderValidator(z3c_validator.SimpleFieldValidator):
	""" z3c.form validator class for easyform fields """
	def validate(self, value):
	""" Validate field by TValidator """
	super(FieldExtenderValidator, self).validate(value)
	efield = IFieldExtender(self.field)
	validators = getattr(efield, "validators", [])
	if validators:
	for validator in validators:
	vmethod = queryUtility(IFieldValidator, name=validator)
	if not vmethod:
	continue
	res = vmethod(value)
	if res:
	raise Invalid(res)
	TValidator = getattr(efield, "TValidator", None)
	if TValidator:
	try:
	cerr = get_expression(self.context, TValidator, value=value)
	except Exception as e:
	raise Invalid(e)
	if cerr:
	raise Invalid(cerr)

This FieldExtenderValidator only adapts fields directly on IEasyFormForm, which are fields in the default 'group'. But the fields in the fieldselts are in an IGroup (or actually an plone.z3cform.fieldsets.group.Group object), not an IEasyForm, so the FieldExtenderValidator is never called for fields in fieldsets.

Gonna patch the 1.x branch directly and provide a pull request with added tests for 2.x