Add support for Python 3, Plone 5.2 and Plone 6 #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
reviewed
Dec 20, 2021
|
This is ready for merging. |
lazy-object-proxy > 1.6.0 is not compatible with Python 2
wesleybl
requested changes
Jan 31, 2022
The default Python 3 isort rules are different from the Python 2 isort rules. So we need to ignore I004 in Python 2.
Use Products.CMFPlone.utils.safe_text instead of Products.CMFPlone.utils.safe_unicode. safe_unicode is deprecated.
Plone already install it.
We already have part rebuild_i18n-sh in buildout.
Tests in Plone 5.2 doesn't install the product into portal_quickinstaller. So, to make reinstall in portal_quickinstaller, we need to install the product in portal_quickinstaller.
Since we don't use RequireJS, compile must be false. Also renames the configuration file to bootstrapjs.xml.
So, when we go to fix the robot tests, this will already be working
Avoid error: Module build failed: BrowserslistError: Unknown browser query `dead` Ref: browserslist/browserslist#266 (comment)
wesleybl
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.