Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plone5.2 and Python2.7 support #891

Closed
cleberjsantos opened this issue Apr 7, 2021 · 13 comments
Closed

Plone5.2 and Python2.7 support #891

cleberjsantos opened this issue Apr 7, 2021 · 13 comments

Comments

@cleberjsantos
Copy link
Member

No description provided.

@cleberjsantos
Copy link
Member Author

WIP: https://github.com/collective/collective.cover/tree/plone52

@cleberjsantos cleberjsantos changed the title Plone 5 support Plone5.2 and Python2.7 support Apr 9, 2021
@wesleybl
Copy link
Member

@cleberjsantos thanks for your work! I am interested in getting collective.cover working on Plone 5.2 in the near future. Do you really think it's necessary to maintain Python 2 support? Can I continue your work from copy of your branch?

@hvelarde , are the changes on this branch OK for you?

@cleberjsantos
Copy link
Member Author

@wesleybl I not consider it ready for use in Plone 5.2 with Python3, currently we use collective.cover with Plone5.2 and Python 2.7 (Demo. https://idgx.dev/), we chose to run it that way, because some requeriments of collective.cover that are not compatible with Python 3 ( Eg. #747) and we lacked time to fix everything.

But my plan is to fix these issues to also migrate everything to Plone5.2 and Python3, and, yes, you can continue contribute, it will be very worthwhile for all :)

@hvelarde
Copy link
Member

hvelarde commented Sep 9, 2021

@wesleybl IIRC you have to work over 2 different issues to bring Python 3 compatibility closer; check:

https://github.com/collective/collective.cover/issues?q=is%3Aissue+is%3Aopen+label%3A%22python+3%22

the rest of the code base must already work OOTB; I don't recommend to keep Cleber's work because it must be outdated.

@mauritsvanrees
Copy link
Member

I checked out the plone52 branch, but it fails to startup, complaining about a missing file src/collective/cover/browser/static/resources.pt. @cleberjsantos do you have an uncommitted file locally?

@mauritsvanrees
Copy link
Member

src/collective/cover/browser/static/ is in the .gitignore file, that explains why you did not see that the file needed to be committed.

@mauritsvanrees
Copy link
Member

Ah, right, I can't just use a checkout, I have to run webpack first. Thanks.

@mauritsvanrees
Copy link
Member

Anyway, a few dependencies do not work yet on Python 3, which is what I want to run it on, so for the moment this is a too big hurdle.

@cleberjsantos
Copy link
Member Author

My plan is to fix these issues to also migrate everything to Plone5.2 and Python3, we chose to run it that way, because some requeriments of collective.cover that are not compatible with Python 3 ( Eg. #747), but, soon :)

@wesleybl wesleybl mentioned this issue Sep 27, 2021
@wesleybl
Copy link
Member

@cleberjsantos I rebase with the master. I think we can create a PR so that they are not more changes than they already have.

@wesleybl
Copy link
Member

@cleberjsantos I rebase again. Please open a PR.

@wesleybl
Copy link
Member

This was done in #900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants