-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plone5.2 and Python2.7 support #891
Comments
@cleberjsantos thanks for your work! I am interested in getting collective.cover working on Plone 5.2 in the near future. Do you really think it's necessary to maintain Python 2 support? Can I continue your work from copy of your branch? @hvelarde , are the changes on this branch OK for you? |
@wesleybl I not consider it ready for use in Plone 5.2 with Python3, currently we use collective.cover with Plone5.2 and Python 2.7 (Demo. https://idgx.dev/), we chose to run it that way, because some requeriments of collective.cover that are not compatible with Python 3 ( Eg. #747) and we lacked time to fix everything. But my plan is to fix these issues to also migrate everything to Plone5.2 and Python3, and, yes, you can continue contribute, it will be very worthwhile for all :) |
@wesleybl IIRC you have to work over 2 different issues to bring Python 3 compatibility closer; check: the rest of the code base must already work OOTB; I don't recommend to keep Cleber's work because it must be outdated. |
I checked out the |
|
Ah, right, I can't just use a checkout, I have to run webpack first. Thanks. |
Anyway, a few dependencies do not work yet on Python 3, which is what I want to run it on, so for the moment this is a too big hurdle. |
My plan is to fix these issues to also migrate everything to Plone5.2 and Python3, we chose to run it that way, because some requeriments of collective.cover that are not compatible with Python 3 ( Eg. #747), but, soon :) |
@cleberjsantos I rebase with the master. I think we can create a PR so that they are not more changes than they already have. |
@cleberjsantos I rebase again. Please open a PR. |
This was done in #900 |
No description provided.
The text was updated successfully, but these errors were encountered: