Add CI build for integration with plone.app.contenttypes #482
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvelarde
force-pushed
the
dexterity-only
branch
from
07efa47
to
cce6c43
Compare
|
DX only has a image attribute and also does not accept a image but |
hvelarde
force-pushed
the
dexterity-only
branch
from
d58ac9f
to
cea4803
Compare
hvelarde
force-pushed
the
dexterity-only
branch
from
cea4803
to
6170b8b
Compare
hvelarde
force-pushed
the
dexterity-only
branch
from
6170b8b
to
9f81b1c
Compare
|
this is now a blocker for #576 |
hvelarde
force-pushed
the
dexterity-only
branch
3 times, most recently
from
5686e17
to
c89a29c
Compare
| mime = obj.lookupMime(obj.getField('file').getContentType(obj)) | ||
| size = obj.get_size() | ||
|
|
||
| try: |
hvelarde
force-pushed
the
dexterity-only
branch
2 times, most recently
from
6705d26
to
805b80a
Compare
|
@idgserpro do you mind help me testing this branch? |
hvelarde
force-pushed
the
dexterity-only
branch
2 times, most recently
from
4816087
to
5447036
Compare
|
@rodfersou please review and merge. |
hvelarde
force-pushed
the
dexterity-only
branch
3 times, most recently
from
a7c75d0
to
6138b68
Compare
Even as collective.cover has been in production using plone.app.contenttypes for more than 2 years in many sites, we haven't deal with testing that in CI. Many changes were made here to achieve compatibility and fix some errors: - testing content creation was refactored to simplify it - Dexterity Image content was removed as is no longer necessary (test case is covered by using plone.app.contenttypes) - a bunch of hacks to deal with Archetypes/Dexterity API incompatibilites were included - RF collection tile test was refactored and finally fixed (I hope so) - documentation was updated to include a known good versions of packages involved This is a huge step in the search of Plone 5 compatibility.
hvelarde
force-pushed
the
dexterity-only
branch
3 times, most recently
from
a4f9108
to
fb6467d
Compare
hvelarde
force-pushed
the
dexterity-only
branch
4 times, most recently
from
49684b7
to
5e9b0cc
Compare
We ignore some tests are randomly failing under Plone 4.2.
hvelarde
added a commit
that referenced
this pull request
Mar 4, 2016
Add CI build for integration with plone.app.contenttypes
|
@hvelarde, no need for changelog in this one? |
|
mostly changes on test infrastructure because of incompatibilities among Archetypes and Dexterity and some bug fixes; but, yes, you are probably right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even with collective.cover being in production using plone.app.contenttypes for more than 2 years in many sites, we haven't dealt with testing that in CI.
Many changes were made here to achieve compatibility and fix some errors:
This is a huge step in the search of Plone 5 compatibility.