Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Atualizar collective.cover para 1.0a12 #265

Closed
hvelarde opened this issue Jan 11, 2016 · 11 comments
Closed

Atualizar collective.cover para 1.0a12 #265

hvelarde opened this issue Jan 11, 2016 · 11 comments
Assignees
@idgserpro
Labels
enhancement
Milestone
1.1.4

Comments

@hvelarde
Copy link
Member

a versão 1.0a12 do collective.cover foi liberada faz um par de messes já e inclui algumas melhorias e correções interessantes:

https://pypi.python.org/pypi/collective.cover/1.0a12#a12-2015-11-16

sugiro atualizar o IDGB para utilizar esta nova versão.

os riscos são mínimos e um upgrade step está disponibilizado no pacote.
@idgserpro idgserpro mentioned this issue Jan 19, 2016
Closed
@idgserpro
Copy link
Member

Precisamos resolver esse relato em tiles plonegovbr/brasil.gov.tiles#132 pois é esse erro que justificou a pinagem do collective.cover do tiles para 1.0a9. - Feito

@idgserpro
Copy link
Member

@hvelarde também precisamos de um release do collective.cover o mais rápido possível: lançando a versão 1.0a13, já vale a pena testarmos nessa versão e fecharmos esse relato numa versão mais atual do collective.cover.

Grande parte do "stress" dessa demanda já foi gasto no relato plonegovbr/brasil.gov.tiles#132, mas vale a pena simular a atualização em outros cenários.

@idgserpro idgserpro self-assigned this Feb 19, 2016
@hvelarde
Copy link
Member Author

vou agendar isso para a próxima semana; deixa ver se consigo fechar collective/collective.cover#482 também.

@idgserpro
Copy link
Member

Com a versão 1.0a13 ganhamos o seguinte problema: plonegovbr/brasil.gov.tiles#134 (comment)

@idgserpro
Copy link
Member

Mais um problema ao acessar http://localhost:8080/Plone/home/compose:

Testado numa instância 1.0.5, adicionado o brasil.gov.portal 1.1.3 e o collective.cover do master, e rodando todos os upgradeSteps.

Traceback (innermost last):
  Module ZPublisher.Publish, line 138, in publish
  Module ZPublisher.mapply, line 77, in mapply
  Module ZPublisher.Publish, line 48, in call_object
  Module grokcore.view.components, line 150, in __call__
  Module grokcore.view.components, line 154, in _render_template
  Module five.grok.components, line 130, in render
  Module zope.pagetemplate.pagetemplate, line 132, in pt_render
  Module five.pt.engine, line 93, in __call__
  Module z3c.pt.pagetemplate, line 163, in render
  Module chameleon.zpt.template, line 258, in render
  Module chameleon.template, line 171, in render
  Module 8a578fd9432184a75db5ecc426166b02.py, line 293, in render
  Module 61649693077e4b9226869312ae8810c9.py, line 1392, in render_master
  Module 61649693077e4b9226869312ae8810c9.py, line 612, in render_content
  Module 8a578fd9432184a75db5ecc426166b02.py, line 226, in __fill_main
  Module five.pt.expressions, line 161, in __call__
  Module collective.cover.layout, line 135, in render_compose
  Module zope.browserpage.viewpagetemplatefile, line 83, in __call__
  Module zope.browserpage.viewpagetemplatefile, line 51, in __call__
  Module zope.pagetemplate.pagetemplate, line 132, in pt_render
  Module five.pt.engine, line 93, in __call__
  Module z3c.pt.pagetemplate, line 163, in render
  Module chameleon.zpt.template, line 258, in render
  Module chameleon.template, line 171, in render
  Module 74717bfdfbe5023e45e1e07167bc4b33.py, line 115, in render
  Module collective.cover.layout, line 87, in render_section
  Module zope.browserpage.viewpagetemplatefile, line 83, in __call__
  Module zope.browserpage.viewpagetemplatefile, line 51, in __call__
  Module zope.pagetemplate.pagetemplate, line 132, in pt_render
  Module five.pt.engine, line 93, in __call__
  Module z3c.pt.pagetemplate, line 163, in render
  Module chameleon.zpt.template, line 258, in render
  Module chameleon.template, line 171, in render
  Module acebf9b47c7ce15d5578007c8cc9231f.py, line 349, in render
  Module collective.cover.layout, line 89, in render_section
  Module zope.browserpage.viewpagetemplatefile, line 83, in __call__
  Module zope.browserpage.viewpagetemplatefile, line 51, in __call__
  Module zope.pagetemplate.pagetemplate, line 132, in pt_render
  Module five.pt.engine, line 93, in __call__
  Module z3c.pt.pagetemplate, line 163, in render
  Module chameleon.zpt.template, line 258, in render
  Module chameleon.template, line 171, in render
  Module f606b3f1dbd11e78de84b9d4bcf3b8fd.py, line 349, in render
  Module collective.cover.layout, line 103, in render_section
  Module zope.browserpage.viewpagetemplatefile, line 83, in __call__
  Module zope.browserpage.viewpagetemplatefile, line 51, in __call__
  Module zope.pagetemplate.pagetemplate, line 132, in pt_render
  Module five.pt.engine, line 93, in __call__
  Module z3c.pt.pagetemplate, line 163, in render
  Module chameleon.zpt.template, line 258, in render
  Module chameleon.template, line 191, in render
  Module chameleon.template, line 171, in render
  Module 715c1582b54e0052fa0c0ab54237b9d2.py, line 407, in render
  Module collective.cover.layout, line 157, in get_content_portal_type
AttributeError: 'NoneType' object has no attribute 'portal_type'

 - Expression: "layout/render_compose"
 - Filename:   ... -py2.7.egg/collective/cover/browser/templates/compose.pt
 - Location:   (line 34: col 31)
 - Source:     tal:replace="structure layout/render_compose" />
                                      ^^^^^^^^^^^^^^^^^^^^^
 - Expression: "python:view.get_content_portal_type(tile_type, tile_id)"
 - Filename:   ... dev0-py2.7.egg/collective/cover/layout_templates/tile.pt
 - Location:   (line 51: col 56)
 - Source:     ... ype python:view.get_content_portal_type(tile_type, tile_id);
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 - Arguments:  repeat: {...} (0)
               context: <ImplicitAcquisitionWrapper home at 0xb3e72f54L>
               views: <ViewMapper - at 0xb18491acL>
               has_subitem: False
               args: <tuple - at 0xb755402cL>
               wrapped_repeat: {...} (0)
               css_id: tile-ecf0f648a9a44a569dba07643a7449e4
               loop: {...} (0)
               nothing: <NoneType - at 0x81ad6b4>
               tile_id: ecf0f648a9a44a569dba07643a7449e4
               target_language: <NoneType - at 0x81ad6b4>
               tile_title: Header
               default: <object - at 0xb757a828L>
               tile_type: standaloneheader
               request: <instance - at 0xb2df9aecL>
               modules: <TraversableModuleImporter - at 0xb62ef6acL>
               tile_url: @@standaloneheader/ecf0f648a9a44a569dba07643a7449e4
               options: {...} (3)
               mode: compose
               template: <ViewPageTemplateFile - at 0xb2e490acL>
               translate: <function translate at 0xb19740d4L>
               section: {...} (6)
               view: <PageLayout layout at 0xb357cc2cL>

@idgserpro
Copy link
Member

O erro acima ocorre nos seguintes tiles adicionados pelo profile inicial de conteúdo do brasil.gov.portal:

<Products.Five.metaclass.HeaderTile object at 0xb181118c>
{'uuid': u'532ac055d98442068f0b5471cf0ebb99', 'title': None, 'css_class': None, 'link_url': u'http://www.brasil.gov.br', 'link_text': u'Saiba mais sobre a editoria'}

<Products.Five.metaclass.HeaderTile object at 0xb1872c4c>
{'uuid': u'b4fb13f666ae41c6ab06737a78ef46c7', 'title': u'Nome da lista', 'css_class': None, 'link_url': u'http://tv1-lnx-04.grupotv1.com/portalmodelo/coluna-de-menus/noticias/copy3_of_titulo-da-noticia-entre-35-e-90-caracteres-com-espaco', 'link_text': None}

Curioso que de todos os itens dessa tela (inclusive outros HeaderTile), apenas esses dois deram problema:

<Products.Five.metaclass.NITFBasicTile object at 0xb0cf5cac>
<Products.Five.metaclass.NITFBasicTile object at 0xb0cf57ac>
<Products.Five.metaclass.NITFBasicTile object at 0xb0cf54cc>
<Products.Five.metaclass.NITFBasicTile object at 0xb107362c>
<Products.Five.metaclass.NITFBasicTile object at 0xb107380c>
<Products.Five.metaclass.NITFBasicTile object at 0xb107302c>
<Products.Five.metaclass.NITFBasicTile object at 0xb10c9d8c>
<Products.Five.metaclass.HeaderTile object at 0xb10c9d8c>
{'uuid': u'532ac055d98442068f0b5471cf0ebb99', 'title': None, 'css_class': None, 'link_url': u'http://www.brasil.gov.br', 'link_text': u'Saiba mais sobre a editoria'}
<Products.Five.metaclass.HeaderTile object at 0xb10c9d8c>
<Products.Five.metaclass.NITFBasicTile object at 0xb10c904c>
<Products.Five.metaclass.NITFBasicTile object at 0xb10c902c>
<Products.Five.metaclass.NITFBasicTile object at 0xb10c9d8c>
<Products.Five.metaclass.HeaderTile object at 0xb107304c>
<Products.Five.metaclass.NITFBasicTile object at 0xb1275f2c>
<Products.Five.metaclass.NITFBasicTile object at 0xb10c95cc>
<Products.Five.metaclass.NITFBasicTile object at 0xb10c9fec>
<Products.Five.metaclass.NITFBasicTile object at 0xb10c9c6c>
<Products.Five.metaclass.NITFBasicTile object at 0xb10c998c>
<Products.Five.metaclass.NITFBasicTile object at 0xb10c920c>
<Products.Five.metaclass.HeaderTile object at 0xb10c924c>
<Products.Five.metaclass.HeaderTile object at 0xb15e338c>
{'uuid': u'b4fb13f666ae41c6ab06737a78ef46c7', 'title': u'Nome da lista', 'css_class': None, 'link_url': u'http://tv1-lnx-04.grupotv1.com/portalmodelo/coluna-de-menus/noticias/copy3_of_titulo-da-noticia-entre-35-e-90-caracteres-com-espaco', 'link_text': None}
<Products.Five.metaclass.NITFBasicTile object at 0xb15e33ec>
<Products.Five.metaclass.NITFBasicTile object at 0xb15e34ac>
<Products.Five.metaclass.NITFBasicTile object at 0xb15e33ec>
<Products.Five.metaclass.NITFBasicTile object at 0xb15e34ac>
<Products.Five.metaclass.HeaderTile object at 0xb15e33ec>

O erro ocorre ao tentar buscar um objeto pelo método uuidToObject(uuid) de plone.app.uuid.utils: por algum motivo, não encontra nada com esses uuids no catalog e dá erro. @hvelarde sabe se houve alguma mudança na forma como era persistido em 1.0a6 e agora no 1.0a13 pra ter esse tipo de erro? Porque será que só nesses dois deu erro sendo que eles são praticamente idênticos a outro HeaderTile?

@idgserpro
Copy link
Member

Acabamos de fazer um teste, com o collective.cover 1.0a13, mas sem executar os upgradeSteps, tanto do brasil.gov.portal, quanto do collective.cover, e o erro é o mesmo.

@idgserpro
Copy link
Member

O erro parece ser uma referência a um uuid de um objeto que não existe no ZODB, mas está persistido como referência num tile.

Isso acontece porque no data.json de brasil.gov.portal há a referência a esse uuid na hora de criar o tile, mas não há objeto correspondente.

Acho inclusive que não faz sentido haver essa referência no tipo de tile "Header" já que a única coisa que ele faz é ser um cabeçalho.

Outro relato será aberto para tratar isso.

@hvelarde
Copy link
Member Author

acho que vão ter que revisar os overrides mesmo; temos vários sites atualizados na versão 1.0a12 sem problema nenhum.

@idgserpro
Copy link
Member

Relato aberto no collective.cover já que outros efeitos colaterais foram identificados para o 1.0a13.

collective/collective.cover#588

@idgserpro idgserpro mentioned this issue Mar 1, 2016
Merged
@hvelarde hvelarde modified the milestone: 1.1.4 Mar 11, 2016
@hvelarde
Copy link
Member Author

feito em plonegovbr/portalpadrao.release@4525f74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@idgserpro idgserpro

Labels
enhancement
Projects
None yet
Milestone
1.1.4
Development

No branches or pull requests
2 participants
@hvelarde @idgserpro