Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: migrate off of protobuf.js #27335

Closed
couchand opened this issue Jul 10, 2018 · 8 comments
Closed

ui: migrate off of protobuf.js #27335

couchand opened this issue Jul 10, 2018 · 8 comments
Assignees
Labels
A-build-system A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. no-issue-activity S-3-productivity Severe issues that impede the productivity of CockroachDB developers. T-dev-inf X-stale
Projects

Comments

@couchand
Copy link
Contributor

The library we currently use to generate JS code from protobuf definitions is dcodeIO/protobuf.js. Unfortunately, this library has given us numerous problems in the past. Many of these issues arise from a variety of uncommon and problematic design decisions. This, plus recent lack of activity in the repo, raise the question of the wisdom of using this libray long term. It's starting to look like we should cut our losses and investigate alternatives.

One related issue is #20109, the suggestion to stop sending protos across the wire, but instead use JSON. Even in that case, though, we want to use a library to generate our TypeScript typings for the responses, so this issue is still relevant.

Assigning to @benesch per our meat-space conversation.

@couchand couchand added C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. S-3-productivity Severe issues that impede the productivity of CockroachDB developers. A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. A-build-system labels Jul 10, 2018
@vilterp
Copy link
Contributor

vilterp commented Jul 10, 2018

So what would we use to generate TS typings from protos?

@benesch
Copy link
Contributor

benesch commented Jul 10, 2018 via email

@Fale
Copy link

Fale commented Jul 13, 2018

Could wasm be a solution for cockroach? moving the dashboard from JS to Go would make everything easier in my opinion

@benesch
Copy link
Contributor

benesch commented Jul 15, 2018

Hi @Fale, thanks for the suggestion. Unfortunately the Go/Wasm ecosystem is still quite immature, and we have quite a bit of TypeScript code that would need to be rewritten. I'm afraid it's unlikely to be a solution we'll pursue.

@tamird
Copy link
Contributor

tamird commented Jul 16, 2018

@couchand
Copy link
Contributor Author

@tamird
Copy link
Contributor

tamird commented Oct 24, 2018 via email

@knz knz unassigned benesch Jan 13, 2019
@couchand couchand added this to Landing Pad in Web UI Jan 15, 2019
@github-actions
Copy link

github-actions bot commented Jun 6, 2021

We have marked this issue as stale because it has been inactive for
18 months. If this issue is still relevant, removing the stale label
or adding a comment will keep it active. Otherwise, we'll close it in
5 days to keep the issue queue tidy. Thank you for your contribution
to CockroachDB!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build-system A-webui-general Issues on the DB Console that span multiple areas or don't have another clear category. C-cleanup Tech debt, refactors, loose ends, etc. Solution not expected to significantly change behavior. no-issue-activity S-3-productivity Severe issues that impede the productivity of CockroachDB developers. T-dev-inf X-stale
Projects
No open projects
Web UI
  
Landing Pad
Development

No branches or pull requests

7 participants