-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Incomplete compile prerequisites and compile error related to yarn #25260
Comments
Those prerequisites are for the source archive, which you can download here: https://binaries.cockroachdb.com/cockroach-v2.0.1.src.tgz The source archive ships a precompiled version of the admin web UI, so you don't need Node and Yarn installed. To build from our Git repository you'll need to adhere to the stricter list of prerequisites in CONTRIBUTING.md: https://github.com/cockroachdb/cockroach/blob/master/CONTRIBUTING.md Apologies that this isn't more clear! |
Sorry about that. Thanks for the help, now it worked. But maybe still one thing left: it seems go-bindata and goimports are not installed nor listed, yet required. Or did I overlooked that as well? |
No need to apologize! Appreciate you taking the time to report this issue. You definitely should not need to manually install go-bindata nor goimports. We pin our dependencies using vendoring, then install them into the bin within the repository. That way we're not relying on whatever version of the tool you happen to have lying around in your PATH. I'm not at all sure what went wrong in your case. You wouldn't happen to have the log from when you ran Make lying around, would you? |
|
Hmm, thanks for sending that along. It's not clear to me if Make is failing to set PATH appropriately or if it failed to install |
Hey @benesch, sorry for the late answer. Running this I also noticed that the dependencies of cockroach are resolved later (after the failing go-bindata call) As the second build.log contains a pull from a different go-bindata repo (github.com/jteeuwen/go-bindata) failing build log: successful build log: |
Not sure if this helps, but I am able to reproduce this. I'm building in a Dockerfile and while it works locally for me it fails in Docker hub. The only difference between the two I can see is the number of cpus - in hub it's limited to 1 cpu, locally I see the build uses To confirm this I ran the docker build locally with |
Producing bindata.go requires go-bindata to be installed. Express this dependency by adding a prerequisite on bin/.bootstrap. Fix cockroachdb#25260. Release note: None
Producing bindata.go requires go-bindata to be installed. Express this dependency by adding a prerequisite on bin/.bootstrap. Fix cockroachdb#25260. Release note: None
27642: Makefile: lots of build fixes r=knz a=benesch A bunch of build system fixes that have piled up. @knz I figure I can get you to review all of them because one of the fixes fixes `make buildshort` by helping make make `make buildshort` build short. Fix #25260. Fix #27608. Co-authored-by: Nikhil Benesch <nikhil.benesch@gmail.com>
Hello,
i just tried compiling the release-2.0 branch (rev. 5608e27) and noticed that yarn is missing in the prerequisites list at https://www.cockroachlabs.com/docs/stable/install-cockroachdb.html#build-from-source-linux
Also an error occurred when compiling:
build/node-run.sh -C ./pkg/ui yarn install
ERROR: [Errno 2] No such file or directory: 'install'
Makefile:322: recipe for target 'pkg/ui/yarn.installed' failed
make: *** [pkg/ui/yarn.installed] Error 1
I ran these commands
git clone -b release-2.0 https://github.com/cockroachdb/cockroach.git
cd cockroach
make build
The text was updated successfully, but these errors were encountered: