[HGCal trigger] Updates in Module sums and Towers

[jbsauvan]

PR description:

• Use all Trigger Cells to build Module Sums
• Use Module Sums from all TCs to build Towers. This change is required to reflect the hardware/firmware.
• Add Tower building in the HFNose

Associated internal PRs and reviews:

• Tower update: include all TCs into TSs PFCal-dev/cmssw#463
• HFnose: adapting calo towers PFCal-dev/cmssw#467
• Use full module sums in towers PFCal-dev/cmssw#477

Related presentation in HGCAL TPG meetings:

• https://indico.cern.ch/event/980323/#2-updates-on-jets-with-towers

PR validation:

Private tests in L1Trigger/L1THGCalUtilities/test:

cmsRun testHGCalL1T_RelValV11_cfg.py
cmsRun testHGCalL1T_multialgo_V11_cfg.py

Tested D49, D60 and D68 workflows

runTheMatrix.py -w upgrade -l 23234.0 --maxSteps=2 
runTheMatrix.py -w upgrade -l 28234.0 --maxSteps=2 
runTheMatrix.py -w upgrade -l 31434.0 --maxSteps=2

---

@mariadalfonso @echapon FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34093/23273

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @jbsauvan (Jean-Baptiste Sauvan) for master.

It involves the following packages:

DataFormats/L1THGCal
L1Trigger/L1THGCal
L1Trigger/L1THGCalUtilities

@cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @amarini, @rovere, @lgray this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

[srimanob]

Please test

[jbsauvan]

I just saw it didn't pass the checks (it seems that I didn't receive a notification from cmsbuild).
I'll fix the errors.

[srimanob]

Please abort

[jbsauvan]

I am fixing the missing header include.
I see there also several warnings regarding deprecated EventSetupRecord::get(ESHandle&), shall I fix them in this PR?

[qliphy]

I am fixing the missing header include.
I see there also several warnings regarding deprecated EventSetupRecord::get(ESHandle&), shall I fix them in this PR?

Not necessary, the warnings are on the codes not touched by you.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34093/23362

• This PR adds an extra 16KB to repository

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-34093/23412

• This PR adds an extra 16KB to repository

[cmsbuild]

Pull request #34093 was updated. @cmsbuild, @rekovic, @srimanob, @cecilecaillol, @kpedro88 can you please check and sign again.

[srimanob]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-084f67/16133/summary.html
COMMIT: 410e593
CMSSW: CMSSW_12_0_X_2021-06-20-2300/slc7_amd64_gcc900
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/34093/16133/install.sh to create a dev area with all the needed externals and cmssw changes.

CMS Clang-Tidy warnings: There are Clang-Tidy warnings. See https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-084f67/16133/llvm-analysis/cmsclangtidy.txt for details.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 38
• DQMHistoTests: Total histograms compared: 2785631
• DQMHistoTests: Total failures: 7
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2785602
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 37 files compared)
• Checked 160 log files, 37 edm output root files, 38 DQM output files
• TriggerResults: no differences found

[srimanob]

@jbsauvan
One small comment, why you update the test configs from D35 to D49, not newer geometry? D49 will be dropped at any moment. However, this is not a showstopper, as it is not my task to check the test config you prefer. Just my curiosity. Thx.

[jbsauvan]

Hi @srimanob
This is because we are using HLT TDR samples for our tests.
But indeed once D49 is dropped, we'll have to switch to other test samples.

[cecilecaillol]

+l1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

[qliphy]

+1