Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tower update: include all TCs into TSs #463

Conversation

echapon
Copy link

@echapon echapon commented Dec 2, 2020

PR description:

This PR adds the possibility to include all trigger cells into the trigger sums (instead of only the unselected TCs). Tower building is then also modified accordingly and only includes trigger sums in this case. A customTriggerSums.py file is added to select one option or the other. The default behaviour is unchanged with this PR and corresponds to "partial trigger sums".

PR validation:

  • passed scram b code-checks, scram b code-format
  • no warnings or errors in compilation
  • Validation using testHGCalL1T_RelValV11_cfg.py:
    • confirm that default behaviour is unchanged
    • with "full trigger sums", results are as expected (larger number of trigger sums, with higher energy; fewer, less energetic towers)

Comment on lines +60 to +64
towermap3D_->buildTowerMap3D(towerMapsPtrs, collTowers);
} else {
/* call to towerMap3D clustering */
towermap3D_->buildTowerMap3D(towerMapsPtrs, collTowers);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could be simplified by removing the else and moving towermap3D_->buildTowerMap3D(towerMapsPtrs, collTowers); outside the if statement, since it is called in any case.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is what I had tried first. But this fails with the following error message (in the default case when partial module sums are used and the code enters the if part):

StdException HGCalTowerMap: Trying to add HGCalTowerMaps with different bins: 2592 and 0

I think this is because towerMapsFromUnclTCs only lives within the if statement now, and dies outside. What I could do, though, is construct this object outside the if statement, which would work too.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. I think it is fine as it is then.

@echapon
Copy link
Author

echapon commented Dec 14, 2020

I forgot to mention that I have checked that the scalar sum of tower pt is unchanged whether "partial" or "full" trigger sums are used, within a couple permils. The plot below was made from 50 events of ttbar PU200, processed with both options.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants