-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use uninitialized edm::Handle in AnalyticalTrackSelector #31035
Conversation
Dereferencing an uninitialized Handle will dereference a nullptr which is undefined behavior.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31035/17529
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: RecoTracker/FinalTrackSelectors @perrotta, @jpata, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
thanks for this technical update, |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Dereferencing an uninitialized Handle will dereference a nullptr which is undefined behavior.
This was found by #30928.
PR validation:
Used #30928 and ran addOn test which was previously failing. Now it succeeds.