Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use uninitialized edm::Handle in TrackstersProducer #31031

Merged
merged 1 commit into from
Aug 5, 2020
Merged

Don't use uninitialized edm::Handle in TrackstersProducer #31031

merged 1 commit into from
Aug 5, 2020

Conversation

Dr15Jones
Copy link
Contributor

PR description:

Dereferencing an uninitialized edm::Handle leads to dereference of a nullptr which is undefined behavior. Rearranged code to avoid using edm::Handles at all.

This was found by #30928.

PR validation:

Built together with #30928 and then ran workflow 23234.0. Previously that pull request failed that workflow but now it succeeds.

@Dr15Jones
Don't use uninitialized edm::Handle in TrackstersProducer
a7efd7a 
Dereferencing an uninitialized edm::Handle leads to dereference
of a nullptr which is undefined behavior. Rearranged code to
avoid using edm::Handles at all.
@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Aug 3, 2020
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

The code-checks are being triggered in jenkins.

@Dr15Jones Dr15Jones mentioned this pull request Aug 3, 2020
Merged
@cmsbuild cmsbuild mentioned this pull request Aug 3, 2020
Merged
@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020 •
edited
Loading

The tests are being triggered in jenkins.
Tested with other pull request(s) #30928,#31029

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-31031/17523

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

RecoHGCal/TICL

@perrotta, @jpata, @kpedro88, @slava77 can you please review it and eventually sign? Thanks.
@felicepantaleo, @riga, @rovere, @apsallid, @sobhatta, @lecriste, @hatakeyamak, @clelange this is something you requested to watch as well.
@silviodonato, @dpiparo, @qliphy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

-1

Tested at: a7efd7a

CMSSW: CMSSW_11_2_X_2020-08-03-1100
SCRAM_ARCH: slc7_amd64_gcc820

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556243/8523/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556243/8523/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556243/8523/summary.html

I found follow errors while testing this PR

Failed tests: AddOn

  • AddOn:

I found errors in the following addon tests:

cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-08-03-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=False globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 3 22:22:08 2020-date Mon Aug 3 21:59:55 2020 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --mc --scenario=pp -n 10 --conditions auto:run3_mc_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_MC.root --fileout file:RelVal_Raw_GRun_MC_HLT_RECO.root : FAILED - time: date Mon Aug 3 22:22:08 2020-date Mon Aug 3 21:59:55 2020 s - exit: 16640
cmsRun /cvmfs/cms-ib.cern.ch/week0/slc7_amd64_gcc820/cms/cmssw/CMSSW_11_2_X_2020-08-03-1100/src/HLTrigger/Configuration/test/OnLine_HLT_GRun.py realData=True globalTag=@ inputFiles=@ : FAILED - time: date Mon Aug 3 22:22:45 2020-date Mon Aug 3 22:00:34 2020 s - exit: 16640
cmsDriver.py RelVal -s HLT:GRun,RAW2DIGI,L1Reco,RECO --data --scenario=pp -n 10 --conditions auto:run3_data_GRun --relval 9000,50 --datatier "RAW-HLT-RECO" --eventcontent FEVTDEBUGHLT --customise=HLTrigger/Configuration/CustomConfigs.L1THLT --era Run3 --processName=HLTRECO --filein file:RelVal_Raw_GRun_DATA.root --fileout file:RelVal_Raw_GRun_DATA_HLT_RECO.root : FAILED - time: date Mon Aug 3 22:22:45 2020-date Mon Aug 3 22:00:34 2020 s - exit: 16640

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556243/8523/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-556243/8523/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020

Comparison job queued.

@silviodonato
Copy link
Contributor

Some differences in the comparison test are expected from #30999 (comment)

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 3, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

+1
Tested at: a7efd7a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8443a/8551/summary.html
CMSSW: CMSSW_11_2_X_2020-08-03-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 4, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d8443a/8551/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2525448
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2525400
  • DQMHistoTests: Total skipped: 47
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
  • Checked 144 log files, 17 edm output root files, 34 DQM output files

@slava77
Copy link
Contributor

slava77 commented Aug 4, 2020 •
edited
Loading

+1

for #31035 bd0cf42

  • technical ; in addition to the edm::Handle case, this PR also gets rid of a mayConsume case
  • jenkins tests pass

@Dr15Jones
Copy link
Contributor Author

ping @kpedro88

@kpedro88
Copy link
Contributor

kpedro88 commented Aug 5, 2020

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 5, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3402e09 into cms-sw:master Aug 5, 2020
@Dr15Jones Dr15Jones deleted the fixTrackstersProducer branch August 5, 2020 15:36
rovere pushed a commit to rovere/cmssw that referenced this pull request Oct 16, 2020
@Dr15Jones @rovere
Backport cms-sw#31031
0210359 
Dereferencing an uninitialized edm::Handle leads to dereference
of a nullptr which is undefined behavior. Rearranged code to
avoid using edm::Handles at all.
rovere pushed a commit to rovere/cmssw that referenced this pull request Oct 22, 2020
@Dr15Jones @rovere
Backport cms-sw#31031
07f34f6 
Dereferencing an uninitialized edm::Handle leads to dereference
of a nullptr which is undefined behavior. Rearranged code to
avoid using edm::Handles at all.
rovere pushed a commit to rovere/cmssw that referenced this pull request Oct 30, 2020
@Dr15Jones @rovere
Backport cms-sw#31031
d1d72cc 
Dereferencing an uninitialized edm::Handle leads to dereference
of a nullptr which is undefined behavior. Rearranged code to
avoid using edm::Handles at all.
rovere pushed a commit to rovere/cmssw that referenced this pull request Nov 8, 2020
@Dr15Jones @rovere
Backport cms-sw#31031
145d973 
Dereferencing an uninitialized edm::Handle leads to dereference
of a nullptr which is undefined behavior. Rearranged code to
avoid using edm::Handles at all.
rovere pushed a commit to rovere/cmssw that referenced this pull request Nov 15, 2020
@Dr15Jones @rovere
Backport cms-sw#31031
8f2f836 
Dereferencing an uninitialized edm::Handle leads to dereference
of a nullptr which is undefined behavior. Rearranged code to
avoid using edm::Handles at all.
@perrotta perrotta mentioned this pull request Nov 19, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
code-checks-approved comparison-available fully-signed orp-approved reconstruction-approved tests-approved upgrade-approved
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.
5 participants
@Dr15Jones @cmsbuild @silviodonato @slava77 @kpedro88