added esConsumes to modules in IMOC/EventVertexGenerators #30485
Conversation
|
This change was made under my supervision. |
|
The code-checks are being triggered in jenkins. |
| } | ||
|
|
||
| BetafuncEvtVtxGenerator::~BetafuncEvtVtxGenerator() {} | ||
|
|
||
| void BetafuncEvtVtxGenerator::beginLuminosityBlock(edm::LuminosityBlock const&, edm::EventSetup const& iEventSetup) { | ||
| update(iEventSetup); | ||
| } | ||
| void BetafuncEvtVtxGenerator::beginRun(const edm::Run&, const edm::EventSetup& iEventSetup) { update(iEventSetup); } |
There was a problem hiding this comment.
Getting from the EventSetup in both the BeginRun and BeginLuminosityBlock is unnecessary and would have required 2 different tokens.
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30485/16659
|
|
A new Pull Request was created by @JamminJones for master. It involves the following packages: IOMC/EventVertexGenerators @cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins.
|
|
+1 |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
PR description:
added esConsumes to 2 modules
PR validation:
the code compiles