-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PPS: direct simulation update A #30466
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30466/16622
|
A new Pull Request was created by @jan-kaspar for master. It involves the following packages: CalibPPS/ESProducers @andrius-k, @kmaeshima, @schneiml, @christopheralanwest, @civanch, @mdhildreth, @cmsbuild, @silviodonato, @franzoni, @jfernan2, @fioriNTU, @tlampen, @tocheng, @pohsun, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins.
|
+1 |
Comparison job queued. |
+1 |
+1 |
+1 |
@davidlange6, @fabiocos, @franzoni, @silviodonato: could you please check (and possibly sign off) the small change in |
+operations |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Several updates to the "direct" simulation of PPS have been presented in the PPS General Meeting:
https://indico.cern.ch/event/927936/contributions/3909004/attachments/2057769/3451230/kaspar_GM_direct_simu.pdf
This PR contains a first part of them (thus the A in the name). Others will follow once the Run3 geometry and RP layout are in place, cf. #30252.
This PR contains the following updates
The "direct" simulation is not used in any central workflow, thus no change in these WFs is expected.
PR validation:
Several validation plots are available in the PPS GM talk linked in the beginning.