Add new MVA tau ID for phase II #30341

swozniewski · 2020-06-23T12:49:51Z

PR description:

Adds new MVA tau ID for phase II to be run on miniAOD.
Presentation: https://indico.cern.ch/event/884712/contributions/3736447/attachments/1981798/3300601/TauIDPhase2_05022020.pdf
Adds a dedicated test analyzer.
Adds production of the ID to the miniAOD sequence triggered by a phase II modifier.

Test command to run the miniAOD sequence with phase II modifier:
cmsDriver.py miniAOD2026 --filein root://eoscms.cern.ch//eos/cms/store/relval/CMSSW_11_1_0_pre8/RelValTTbar_14TeV/GEN-SIM-RECO/PU25ns_110X_mcRun4_realistic_v3_2026D49PU200-v1/20000/FF37C15C-1A4E-794E-B39F-B9B5D1860DAF.root --fileout file:MiniAOD2026.root --mc --eventcontent MINIAODSIM --runUnscheduled --datatier MINIAODSIM --conditions auto:phase2_realistic_T14 --step PAT --nThreads 4 --geometry Extended2026D49 --scenario pp --era Phase2C8 -n 2

PR validation:

Test command shown above successfully runs miniAOD creating the phaseII ID
compiles
code checks pass
format checks pass
unit tests pass
limited matrix tests pass

cmsbuild · 2020-06-23T12:50:10Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-06-23T12:56:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30341/16354

This PR adds an extra 104KB to repository
Found files with invalid states:
- RecoTauTag/RecoTau/plugins/rerunMVAIsolationOnMiniAOD_Phase2.cc:
  - Added: 65825d4
  - Deleted: 5fae4d0
There are other open Pull requests which might conflict with changes you have proposed:
- File PhysicsTools/PatAlgos/python/slimming/miniAOD_tools.py modified in PR(s): Modified muon selection for heavy-ion miniAOD #30237
- File RecoTauTag/RecoTau/plugins/PATTauDiscriminationByMVAIsolationRun2.cc modified in PR(s): [RFC] Test clang-tidy --checks modernize-loop-convert #29935

cmsbuild · 2020-06-23T12:56:40Z

A new Pull Request was created by @swozniewski for master.

It involves the following packages:

PhysicsTools/PatAlgos
RecoTauTag/Configuration
RecoTauTag/RecoTau

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

slava77 · 2020-06-23T13:40:00Z

@cmsbuild please test

cmsbuild · 2020-06-23T13:40:24Z

The tests are being triggered in jenkins.

CMSSW_11_2_X_2020-06-23-1100/slc7_amd64_gcc820: https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/7282/console Started: 2020/06/23 15:46

cmsbuild · 2020-06-23T15:13:44Z

+1
Tested at: 5890534
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e868b2/7282/summary.html
CMSSW: CMSSW_11_2_X_2020-06-23-1100
SCRAM_ARCH: slc7_amd64_gcc820

cmsbuild · 2020-06-23T15:13:46Z

Comparison job queued.

cmsbuild · 2020-06-23T16:59:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e868b2/7282/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 7 differences found in the comparisons
DQMHistoTests: Total files compared: 36
DQMHistoTests: Total histograms compared: 2778811
DQMHistoTests: Total failures: 4
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2778757
DQMHistoTests: Total skipped: 50
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
Checked 152 log files, 16 edm output root files, 36 DQM output files

santocch · 2020-06-24T09:19:56Z

+1

cmsbuild · 2020-07-23T03:57:19Z

Comparison job queued.

cmsbuild · 2020-07-23T05:33:44Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e868b2/8233/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 6 differences found in the comparisons
DQMHistoTests: Total files compared: 34
DQMHistoTests: Total histograms compared: 2526188
DQMHistoTests: Total failures: 7
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 2526134
DQMHistoTests: Total skipped: 47
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 33 files compared)
Checked 144 log files, 17 edm output root files, 34 DQM output files

perrotta · 2020-07-23T07:52:14Z

+1

Specific TauID for Phase2 are defined, and their output stored in Phase2 miniAOD
This increases the Phase2 miniAOD size by O(100 B)/evt, which can be recovered as soon as the contemporary storage of "2017" tau IDs kept for comparison can be removed from the event content
Jenkins tests pass and only show the above differences in the Phase2 miniAOD outputs

kpedro88 · 2020-07-23T14:11:40Z

+upgrade

santocch · 2020-07-24T15:05:44Z

+1

cmsbuild · 2020-07-24T15:06:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

silviodonato · 2020-07-25T08:21:07Z

+1

slava77 · 2020-07-25T20:35:17Z

after this PR was merged we have some non-reproducible behavior in phase-2 slimmedTaus plots (it starts from CMSSW_11_2_X_2020-07-25-1100 IB)

slava77 · 2020-07-25T20:45:03Z

RecoTauTag/RecoTau/src/PFRecoTauClusterVariables.cc

+          mvaInput[3] = neutralIsoPtSum;               //tauID("neutralIsoPtSum");
+          mvaInput[4] = puCorrPtSum;                   //tauID("puCorrPtSum");
+          mvaInput[5] = photonPtSumOutsideSignalCone;  //tauID("photonPtSumOutsideSignalCone");
+          mvaInput[7] = tauDecayMode;                  //tau.decayMode();


I suppose this was meant to be 6.
I guess this is the origin of random results in jenkins tests

Another example of the need for #29818...

cmsbuild added this to the CMSSW_11_2_X milestone Jun 23, 2020

cmsbuild added analysis-pending code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jun 23, 2020

swozniewski changed the title ~~Cmssw 11 1 0 x tau pog phase2 mvaiso rebased~~ Add new MVA tau ID for phase II Jun 23, 2020

cmsbuild added code-checks-approved and removed code-checks-pending labels Jun 23, 2020

cmsbuild added tests-started and removed tests-pending labels Jun 23, 2020

cmsbuild added tests-approved and removed tests-started labels Jun 23, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jun 23, 2020

cmsbuild added analysis-approved and removed analysis-pending labels Jun 24, 2020

cmsbuild mentioned this pull request Jun 24, 2020

reMiniAOD relval workflows for heavy ions #30354

Merged

cmsbuild mentioned this pull request Jul 3, 2020

Clean BuildFiles in reco plugins #30535

Merged

cmsbuild added tests-approved and removed tests-started labels Jul 23, 2020

cmsbuild added comparison-available and removed comparison-pending labels Jul 23, 2020

cmsbuild added reconstruction-approved and removed reconstruction-pending labels Jul 23, 2020

cmsbuild added upgrade-approved and removed upgrade-pending labels Jul 23, 2020

cmsbuild mentioned this pull request Jul 24, 2020

Switch to heavy-ion jets in HI miniAOD #30898

Merged

cmsbuild added analysis-approved fully-signed and removed analysis-pending pending-signatures labels Jul 24, 2020

cmsbuild added orp-approved and removed orp-pending labels Jul 25, 2020

cmsbuild merged commit a99e3f3 into cms-sw:master Jul 25, 2020

slava77 reviewed Jul 25, 2020

View reviewed changes

This was referenced Jul 25, 2020

speed up TrackExtenderWithMTDT #30902

Merged

fix index typo in PFRecoTauClusterVariables #30919

Merged

makortel mentioned this pull request Jul 28, 2020

bumping versions of python(2) tools cms-sw/cmsdist#6108

Merged

mbluj mentioned this pull request Sep 24, 2020

Add anti-electron tauID for phase2 #31470

Merged

mbluj deleted the CMSSW_11_1_0_X_tau-pog_phase2-mvaiso_rebased branch October 10, 2023 10:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add new MVA tau ID for phase II #30341

Add new MVA tau ID for phase II #30341

swozniewski commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

slava77 commented Jun 23, 2020

cmsbuild commented Jun 23, 2020 •

edited

Loading

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

santocch commented Jun 24, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

perrotta commented Jul 23, 2020 •

edited

Loading

kpedro88 commented Jul 23, 2020

santocch commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

silviodonato commented Jul 25, 2020

slava77 commented Jul 25, 2020

slava77 Jul 25, 2020

kpedro88 Jul 25, 2020

Add new MVA tau ID for phase II #30341

Add new MVA tau ID for phase II #30341

Conversation

swozniewski commented Jun 23, 2020

PR description:

PR validation:

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

slava77 commented Jun 23, 2020

cmsbuild commented Jun 23, 2020 • edited Loading

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

cmsbuild commented Jun 23, 2020

santocch commented Jun 24, 2020

cmsbuild commented Jul 23, 2020

cmsbuild commented Jul 23, 2020

perrotta commented Jul 23, 2020 • edited Loading

kpedro88 commented Jul 23, 2020

santocch commented Jul 24, 2020

cmsbuild commented Jul 24, 2020

silviodonato commented Jul 25, 2020

slava77 commented Jul 25, 2020

slava77 Jul 25, 2020

Choose a reason for hiding this comment

kpedro88 Jul 25, 2020

Choose a reason for hiding this comment

cmsbuild commented Jun 23, 2020 •

edited

Loading

perrotta commented Jul 23, 2020 •

edited

Loading