Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified muon selection for heavy-ion miniAOD #30237

Merged
merged 1 commit into from
Jul 3, 2020

Conversation

mandrenguyen
Copy link
Contributor

PR description:

Modified muon selection for heavy-ion miniAOD

PR validation:

Tested with workflow 159

if this PR is a backport please specify the original PR and why you need to backport that PR:

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30237/16121

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

PhysicsTools/PatAlgos

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @peruzzim, @seemasharmafnal, @mmarionncern, @ahinzmann, @smoortga, @jdolen, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @clelange, @riga, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

please test workflow 159

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 15, 2020

The tests are being triggered in jenkins.
Test Parameters:

@cmsbuild
Copy link
Contributor

+1
Tested at: c698f06
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5e9af/7063/summary.html
CMSSW: CMSSW_11_2_X_2020-06-14-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5e9af/7063/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /data/cmsbld/jenkins/workspace/compare-root-files-short-matrix/data/PR-d5e9af/159.0_HydjetQ_B12_5020GeV_2021_ppReco+HydjetQ_B12_5020GeV_2021_ppReco+DIGIHI2021PPRECO+RECOHI2021PPRECO+ALCARECOHI2021PPRECO+HARVESTHI2021PPRECO

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 36
  • DQMHistoTests: Total histograms compared: 2778811
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2778760
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
  • Checked 152 log files, 16 edm output root files, 36 DQM output files

@perrotta
Copy link
Contributor

@cmsbuild please test with #30354 workflow 140.5611

@perrotta
Copy link
Contributor

please test workflow 140.5611 with #30354
(order matters..)

@perrotta
Copy link
Contributor

perrotta commented Jul 1, 2020

+1

  • The new selection studied for PAT muons in Run3 HI has been compared with the current one thanks to the new HI re-miniAOD workflows defined with reMiniAOD relval workflows for heavy ions #30354: the size of slimmed muons is rather similar to the one obtainable with the current (pp) selection, just a 1.4% size increase for that specific branch (fraction of permil in the overall event size)
  • Jenkins tests pass and show no differences anywhere else

@perrotta
Copy link
Contributor

perrotta commented Jul 1, 2020

@cmsbuild please test workflow 140.5611
(tests still pending seem to prevent this PR being considered as signed)

@slava77
Copy link
Contributor

slava77 commented Jul 1, 2020

@cmsbuild please test workflow 140.5611

it looks like the bot was asleep

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

The tests are being triggered in jenkins.
Test Parameters:

@slava77
Copy link
Contributor

slava77 commented Jul 1, 2020

... that also triggered an update in the signature list

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

+1
Tested at: c698f06
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5e9af/7559/summary.html
CMSSW: CMSSW_11_2_X_2020-06-30-2300
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2020

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5e9af/7559/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 37
  • DQMHistoTests: Total histograms compared: 2784120
  • DQMHistoTests: Total failures: 383
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2783687
  • DQMHistoTests: Total skipped: 50
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 36 files compared)
  • Checked 154 log files, 17 edm output root files, 37 DQM output files

@santocch
Copy link

santocch commented Jul 3, 2020

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 3, 2020

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo (and backports should be raised in the release meeting by the corresponding L2)

@silviodonato
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a0a06fa into cms-sw:master Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants