Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLTTauDQM: conditional plotting #30243

Closed
wants to merge 0 commits into from
Closed

HLTTauDQM: conditional plotting #30243

wants to merge 0 commits into from

Conversation

slehti
Copy link
Contributor

@slehti slehti commented Jun 15, 2020

PR description:

To reduce the number of DQM plots, HLTTau validation is moving to conditional plotting. Normally only a subset of plots are produced, but in case there is a problem, the kVital parameter can be changed to kEverything, in which case all plots are produced.

PR validation:

Tested with CMSSW_11_2_X_2020-06-14-0000

Output of 'runTheMatrix.py -l limited -i all --ibeos'

...
250202.181_TTbar_13UP18+TTbar_13UP18INPUT+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED - time date Mon Jun 15 15:40:56 2020-date Mon Jun 15 14:55:18 2020; exit: 0 0 0 0 0
35 33 31 25 16 4 1 1 1 tests passed, 1 1 1 0 0 0 0 0 0 failed

@cmsbuild cmsbuild added this to the CMSSW_11_2_X milestone Jun 15, 2020
@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30243/16132

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@jfernan2
Copy link
Contributor

@slehti in case you did not notice, you have code format issues to apply before proceeding.
Moreover, from you PR description, you quote:
1 1 1 0 0 0 0 0 0 failed
Did all the workflows in runTheMatrix -l limited pass successfully?
Thanks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@slehti
Copy link
Contributor Author

slehti commented Jun 22, 2020

Class renaming, after which I get
23234.1001_TTbar_14TeV+RecoFullGlobal_TestOldDigi_2026D49+HARVESTFullGlobal_2026D49 Step0-PASSED Step1-PASSED - time date Thu Jun 18 14:48:03 2020-date Thu Jun 18 14:40:54 2020; exit: 0 0
250202.181_TTbar_13UP18+TTbar_13UP18INPUT+PREMIXUP18_PU25+DIGIPRMXLOCALUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25 Step0-PASSED Step1-PASSED Step2-PASSED Step3-PASSED Step4-PASSED - time date Thu Jun 18 15:35:02 2020-date Thu Jun 18 14:44:30 2020; exit: 0 0 0 0 0
36 35 33 26 16 4 1 1 1 tests passed, 0 0 0 0 0 0 0 0 0 failed

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30243/16322

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@jfernan2
Copy link
Contributor

@slehti Now you have code-format issues

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30243/16380

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @slehti for master.

It involves the following packages:

DQMOffline/Trigger

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@missirol, @mtosi, @Fedespring, @calderona, @HuguesBrun, @jhgoh, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 24, 2020 •
edited
Loading

The tests are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@slava77
Copy link
Contributor

slava77 commented Jul 15, 2020

-1

looks like a bad merge or a wrong branch

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30243/17000

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@slehti slehti closed this Jul 15, 2020
@slehti slehti force-pushed the HLTTauValidation_ConditionalPlotting branch from 7320ac2 to 92997c6 Compare July 15, 2020 13:26
This was referenced Jul 15, 2020
Closed
Closed
@slehti slehti mentioned this pull request Aug 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
alca-pending analysis-pending code-checks-rejected comparison-pending core-pending daq-pending db-pending dqm-pending fastsim-pending generators-pending geometry-pending heterogeneous-pending hlt-pending l1-pending operations-pending orp-pending pdmv-pending pending-signatures reconstruction-rejected simulation-pending tests-pending upgrade-pending visualization-pending xpog-pending
Projects
None yet
Milestone
CMSSW_11_2_X
Development

Successfully merging this pull request may close these issues.
5 participants
@slehti @cmsbuild @jfernan2 @silviodonato @slava77