-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply code checks to the FWCore packages #29885
Conversation
Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release
Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release
Enabled checks: boost-use-to-string misc-uniqueptr-reset-release modernize-deprecated-headers modernize-make-shared modernize-use-bool-literals modernize-use-equals-delete modernize-use-nullptr modernize-use-override performance-unnecessary-copy-initialization readability-container-size-empty readability-redundant-string-cstr readability-static-definition-in-anonymous-namespace readability-uniqueptr-delete-release
The code-checks are being triggered in jenkins. |
@cmsbuild, please test |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29885/15457
|
The tests are being triggered in jenkins. |
A new Pull Request was created by @fwyzard (Andrea Bocci) for master. It involves the following packages: FWCore/Framework @makortel, @smuzaffar, @cmsbuild, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Looks good to me. Wonder why these changes didn't happen before. |
Me too. |
clang-tidy changes for header files are triggered via the source files (.cc, .cpp) files of the package. We had noticed that some header files (order of 100+) missed clang-tidy changes as they were only include via sources of other packages. |
Comparison job queued. |
Unrelated ? |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
-1 Tested at: 5ab70e2 CMSSW: CMSSW_11_1_X_2020-05-18-1100 I found follow errors while testing this PR Failed tests: UnitTests
I found errors in the following unit tests: ---> test testTauEmbeddingProducers had ERRORS |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
The unit test failure should be fixed in |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Apply
clang-tidy
automated code changes.Apply
clang-format
automated code formatting.