Enable additional code checks (effect of #29858) #29863

fwyzard · 2020-05-17T14:14:18Z

Show the effect of #29858 on top of the CMSSW_11_1_X branch.

The changes were applied with

scram b -j`nproc` llvm-ccdb
cat $CMSSW_BASE/compile_commands.json | grep '"file"' | cut -d'"' -f4 | xargs $(scram tool tag llvm LLVM_BASE)/share/clang/run-clang-tidy.py -header-filter "$CMSSW_BASE/src/.*" -j`nproc` -fix -format

cmsbuild · 2020-05-17T14:16:20Z

The code-checks are being triggered in jenkins.

cmsbuild · 2020-05-17T15:03:29Z

-code-checks

ERROR: Build errors found during clang-tidy run.

Calibration/HcalCalibAlgos/plugins/HcalHBHEMuonAnalyzer.cc:350:33: error: expected unqualified-id [clang-diagnostic-error]
      ptGlob_.push_back(RecMuon.->pt());
                                ^
CommonTools/Utils/interface/TH1AddDirectorySentry.h:30:3: warning: deleted member function should be public [modernize-use-equals-delete]
--
Calibration/HcalCalibAlgos/plugins/HcalHBHEMuonHighEtaAnalyzer.cc:506:42: error: expected unqualified-id [clang-diagnostic-error]
            ptGlob_.emplace_back(RecMuon.->pt());
                                         ^
CommonTools/Utils/interface/TH1AddDirectorySentry.h:30:3: warning: deleted member function should be public [modernize-use-equals-delete]
--
Calibration/IsolatedParticles/plugins/HcalRaddamMuon.cc:277:32: error: expected unqualified-id [clang-diagnostic-error]
      PtGlob.push_back(RecMuon.->pt());
                               ^
CommonTools/Utils/interface/TH1AddDirectorySentry.h:30:3: warning: deleted member function should be public [modernize-use-equals-delete]
--
CondFormats/SiPixelObjects/src/PixelFEDLink.cc:49:23: error: expected unqualified-id [clang-diagnostic-error]
        out << theROC.->print(depth);
                      ^
Suppressed 518 warnings (517 in non-user code, 1 with check filters).
--
CondTools/DT/src/DTHVStatusHandler.cc:1146:47: error: no matching function for call to 'distance' [clang-diagnostic-error]
      std::cout << "  ******** SWITCH ON " << std::distance(iter, prev) << " " << iTime << " " << pTime << " " << iSize
                                              ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_iterator_base_funcs.h:138:5: note: candidate template ignored: deduced conflicting types for parameter '_InputIterator' ('__normal_iterator<std::pair<DTHVStatus *, unsigned long long> *, [...]>' vs. '__normal_iterator<const std::pair<DTHVStatus *, unsigned long long> *, [...]>')
--
CondTools/DT/src/DTHVStatusHandler.cc:1153:48: error: no matching function for call to 'distance' [clang-diagnostic-error]
      std::cout << "  ******** SWITCH OFF " << std::distance(iter, prev) << " " << iTime << " " << pTime << " " << iSize
                                               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_iterator_base_funcs.h:138:5: note: candidate template ignored: deduced conflicting types for parameter '_InputIterator' ('__normal_iterator<std::pair<DTHVStatus *, unsigned long long> *, [...]>' vs. '__normal_iterator<const std::pair<DTHVStatus *, unsigned long long> *, [...]>')
--
CondTools/DT/src/DTHVStatusHandler.cc:1166:10: error: no viable overloaded '=' [clang-diagnostic-error]
    iter = next;
         ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_iterator.h:764:11: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from '__normal_iterator<std::vector<std::pair<DTHVStatus *, unsigned long long>, std::allocator<std::pair<DTHVStatus *, unsigned long long> > >::const_pointer, [...]>' to 'const __normal_iterator<std::pair<DTHVStatus *, unsigned long long> *, [...]>' for 1st argument
--
DQM/CSCMonitorModule/plugins/CSCDQM_Collection.cc:291:27: error: expected expression [clang-diagnostic-error]
        while (label.find(''') != std::string::npos) {
                          ^
DQM/CSCMonitorModule/plugins/CSCDQM_Collection.cc:646:7: warning: use range-based for loop instead [modernize-loop-convert]
--
DQM/DTMonitorClient/src/DTLocalTriggerLutTest.cc:107:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerLutTest.cc:109:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerLutTest.cc:259:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerLutTest.cc:261:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerEfficiencyTest.cc:107:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerEfficiencyTest.cc:109:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerTPTest.cc:76:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
Suppressed 2201 warnings (2200 in non-user code, 1 with check filters).
--
DQM/DTMonitorClient/src/DTLocalTriggerTPTest.cc:78:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerTest.cc:115:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerTest.cc:118:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerTest.cc:357:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerTest.cc:359:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTTriggerEfficiencyTest.cc:58:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTTriggerEfficiencyTest.cc:60:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTTriggerLutTest.cc:109:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTTriggerLutTest.cc:111:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTTriggerLutTest.cc:236:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTTriggerLutTest.cc:238:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerSynchTest.cc:105:16: error: no viable overloaded '=' [clang-diagnostic-error]
    trigSource = trigSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
DQM/DTMonitorClient/src/DTLocalTriggerSynchTest.cc:107:16: error: no viable overloaded '=' [clang-diagnostic-error]
      hwSource = hwSource;
               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/basic_string.h:664:7: note: candidate function not viable: 'this' argument has type 'const std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> >', but method is not marked const
--
EventFilter/SiStripRawToDigi/interface/SiStripDetSetVectorFiller.h:107:12: error: no viable overloaded '=' [clang-diagnostic-error]
      iReg = jReg;
           ^
DQM/SiStripMonitorHardware/src/SiStripSpyDigiConverter.cc:244:22: note: in instantiation of member function 'sistrip::DetSetVectorFiller<SiStripRawDigi, false>::createDetSetVector' requested here
--
EventFilter/SiStripRawToDigi/interface/SiStripDetSetVectorFiller.h:107:12: error: no viable overloaded '=' [clang-diagnostic-error]
      iReg = jReg;
           ^
DQM/SiStripMonitorHardware/src/SiStripSpyUnpacker.cc:204:51: note: in instantiation of member function 'sistrip::DetSetVectorFiller<SiStripRawDigi, false>::createDetSetVector' requested here
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:483:5: error: excess elements in scalar initializer [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexDauMask, kRefDisplacedVertexDauBit);
    ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4662:14: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:483:5: error: expected a type [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexDauMask, kRefDisplacedVertexDauBit);
    ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4659:41: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:483:5: error: no viable conversion from returned value of type 'RefType' (aka 'int') to function return type 'reco::PFDisplacedVertexRef' (aka 'Ref<vector<reco::PFDisplacedVertex> >') [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexDauMask, kRefDisplacedVertexDauBit);
    ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4668:10: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:483:12: error: 'auto' not allowed here [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexDauMask, kRefDisplacedVertexDauBit);
           ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4664:43: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:483:12: error: 'auto' not allowed in template argument [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexDauMask, kRefDisplacedVertexDauBit);
           ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4659:32: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:485:5: error: excess elements in scalar initializer [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexMotMask, kRefDisplacedVertexMotBit);
    ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4662:14: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:485:5: error: expected a type [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexMotMask, kRefDisplacedVertexMotBit);
    ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4659:41: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:485:5: error: no viable conversion from returned value of type 'RefType' (aka 'int') to function return type 'reco::PFDisplacedVertexRef' (aka 'Ref<vector<reco::PFDisplacedVertex> >') [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexMotMask, kRefDisplacedVertexMotBit);
    ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4668:10: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:485:12: error: 'auto' not allowed here [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexMotMask, kRefDisplacedVertexMotBit);
           ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4664:43: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:485:12: error: 'auto' not allowed in template argument [clang-diagnostic-error]
    GETREF(auto, kRefDisplacedVertexMotMask, kRefDisplacedVertexMotBit);
           ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4659:32: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:511:58: error: excess elements in scalar initializer [clang-diagnostic-error]
reco::ConversionRef PFCandidate::conversionRef() const { GETREF(auto, kRefConversionMask, kRefConversionBit); }
                                                         ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4662:14: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:511:58: error: expected a type [clang-diagnostic-error]
reco::ConversionRef PFCandidate::conversionRef() const { GETREF(auto, kRefConversionMask, kRefConversionBit); }
                                                         ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4659:41: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:511:58: error: no viable conversion from returned value of type 'RefType' (aka 'int') to function return type 'reco::ConversionRef' (aka 'Ref<vector<reco::Conversion> >') [clang-diagnostic-error]
reco::ConversionRef PFCandidate::conversionRef() const { GETREF(auto, kRefConversionMask, kRefConversionBit); }
                                                         ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4668:10: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:511:65: error: 'auto' not allowed here [clang-diagnostic-error]
reco::ConversionRef PFCandidate::conversionRef() const { GETREF(auto, kRefConversionMask, kRefConversionBit); }
                                                                ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4664:43: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:511:65: error: 'auto' not allowed in template argument [clang-diagnostic-error]
reco::ConversionRef PFCandidate::conversionRef() const { GETREF(auto, kRefConversionMask, kRefConversionBit); }
                                                                ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4659:32: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:518:64: error: excess elements in scalar initializer [clang-diagnostic-error]
reco::VertexCompositeCandidateRef PFCandidate::v0Ref() const { GETREF(auto, kRefV0Mask, kRefV0Bit); }
                                                               ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4662:14: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:518:64: error: expected a type [clang-diagnostic-error]
reco::VertexCompositeCandidateRef PFCandidate::v0Ref() const { GETREF(auto, kRefV0Mask, kRefV0Bit); }
                                                               ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4659:41: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:518:71: error: 'auto' not allowed here [clang-diagnostic-error]
reco::VertexCompositeCandidateRef PFCandidate::v0Ref() const { GETREF(auto, kRefV0Mask, kRefV0Bit); }
                                                                      ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4664:43: note: expanded from macro 'GETREF'
--
DataFormats/ParticleFlowCandidate/src/PFCandidate.cc:518:71: error: 'auto' not allowed in template argument [clang-diagnostic-error]
reco::VertexCompositeCandidateRef PFCandidate::v0Ref() const { GETREF(auto, kRefV0Mask, kRefV0Bit); }
                                                                      ^
DataFormats/ParticleFlowCandidate/src/CountBits.h:4659:32: note: expanded from macro 'GETREF'
--
DataFormats/Provenance/src/IndexIntoFile.cc:495:78: error: no viable overloaded '=' [clang-diagnostic-error]
    for (auto phBegin = runOrLumiIndexes().begin(); phBegin != iEnd; phBegin = phEnd) {
                                                                             ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_iterator.h:764:11: note: candidate function (the implicit copy assignment operator) not viable: no known conversion from '__normal_iterator<std::vector<edm::IndexIntoFile::RunOrLumiIndexes, std::allocator<edm::IndexIntoFile::RunOrLumiIndexes> >::const_pointer, [...]>' to 'const __normal_iterator<edm::IndexIntoFile::RunOrLumiIndexes *, [...]>' for 1st argument
--
DataFormats/Provenance/src/IndexIntoFile.cc:499:19: error: no matching function for call to 'lower_bound' [clang-diagnostic-error]
      auto iRun = std::lower_bound(phBegin, phEnd, el, Compare_Index_Run());
                  ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_algo.h:2023:5: note: candidate template ignored: deduced conflicting types for parameter '_ForwardIterator' ('__normal_iterator<edm::IndexIntoFile::RunOrLumiIndexes *, [...]>' vs. '__normal_iterator<const edm::IndexIntoFile::RunOrLumiIndexes *, [...]>')
--
DataFormats/TrackerRecHit2D/src/SiTrackerMultiRecHit.cc:29:20: error: expected unqualified-id [clang-diagnostic-error]
        if (theHit.->sharesInput(otherhit, all)) {
                   ^
DataFormats/TrackerRecHit2D/src/SiTrackerMultiRecHit.cc:43:22: error: expected unqualified-id [clang-diagnostic-error]
          if (theHit.->sharesInput(otherhit, some))
                     ^
DataFormats/TrackerRecHit2D/src/SiTrackerMultiRecHit.cc:47:20: error: expected unqualified-id [clang-diagnostic-error]
        if (theHit.->sharesInput(other, some))
                   ^
Suppressed 634 warnings (633 in non-user code, 1 with check filters).
--
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/predefined_ops.h:241:17: error: invalid operands to binary expression ('std::pair<unsigned int, DDValue>' and 'const unsigned int') [clang-diagnostic-error]
        { return *__it == _M_value; }
                       ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/external/gcc/8.2.0-bcolbf/lib/gcc/x86_64-unknown-linux-gnu/8.4.0/../../../../include/c++/8.4.0/bits/stl_algo.h:120:8: note: in instantiation of function template specialization '__gnu_cxx::__ops::_Iter_equals_val<const unsigned int>::operator()<__gnu_cxx::__normal_iterator<std::pair<unsigned int, DDValue> *, std::vector<std::pair<unsigned int, DDValue>, std::allocator<std::pair<unsigned int, DDValue> > > > >' requested here
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:291:48: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histoid = "jet_pt_" + flavor + "_taggable" + i;
                                               ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:293:54: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histocontainer_["jet_pt_" + flavor + "_taggable" + i] =
                                                     ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:295:55: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histoid = "jet_pt_uncorr_" + flavor + "_taggable" + i;
                                                      ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:297:61: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histocontainer_["jet_pt_uncorr_" + flavor + "_taggable" + i] =
                                                            ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:299:49: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histoid = "jet_eta_" + flavor + "_taggable" + i;
                                                ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:301:55: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histocontainer_["jet_eta_" + flavor + "_taggable" + i] =
                                                      ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:303:49: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histoid = "jet_eta_" + flavor + "_taggable" + i + "_030";
                                                ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:304:55: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histocontainer_["jet_eta_" + flavor + "_taggable" + i + "_030"] =
                                                      ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:306:49: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histoid = "jet_eta_" + flavor + "_taggable" + i + "_3050";
                                                ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:307:55: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histocontainer_["jet_eta_" + flavor + "_taggable" + i + "_3050"] =
                                                      ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:309:49: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histoid = "jet_eta_" + flavor + "_taggable" + i + "_50";
                                                ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
PhysicsTools/PatExamples/src/PatBTagCommonHistos.cc:310:55: error: invalid operands to binary expression ('basic_string<char, std::char_traits<char>, std::allocator<char> >' and 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >') [clang-diagnostic-error]
    histocontainer_["jet_eta_" + flavor + "_taggable" + i + "_50"] =
                                                      ^
/cvmfs/cms-ib.cern.ch/nweek-02629/slc7_amd64_gcc820/lcg/root/6.18.04-bcolbf5/include/TString.h:531:1: note: candidate function template not viable: no known conversion from 'const std::pair<const int, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > >' to 'const TString' for 2nd argument
--
RecoEgamma/EgammaIsolationAlgos/src/EcalPFClusterIsolation.cc:96:58: error: out-of-line definition of 'computedRVeto' does not match any declaration in 'EcalPFClusterIsolation<reco::RecoChargedCandidate>' [clang-diagnostic-error]
bool EcalPFClusterIsolation<reco::RecoChargedCandidate>::computedRVeto(T1Ref candRef, reco::PFClusterRef pfclu) {
                                                         ^
RecoEgamma/EgammaIsolationAlgos/interface/EcalPFClusterIsolation.h:48:43: note: type of 2nd parameter of member declaration does not match definition ('const reco::PFClusterRef &' (aka 'const Ref<vector<reco::PFCluster> > &') vs 'reco::PFClusterRef' (aka 'Ref<vector<reco::PFCluster> >'))
--
RecoPPS/Local/plugins/TotemRPUVPatternFinder.cc:211:13: error: binding reference of type 'RPData' to value of type 'const RPData' drops 'const' qualifier [clang-diagnostic-error]
    RPData &data = it.second;
            ^
Suppressed 1557 warnings (1556 in non-user code, 1 with check filters).
--
RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc:403:21: error: expected unqualified-id [clang-diagnostic-error]
        thePixelDet.->setActive(isOn);
                    ^
RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc:411:21: error: expected unqualified-id [clang-diagnostic-error]
        thePixelDet.->setActive(true);
                    ^
RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc:416:21: error: expected unqualified-id [clang-diagnostic-error]
        thePixelDet.->setBadRocPositions(badROCs);
                    ^
RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc:418:21: error: expected unqualified-id [clang-diagnostic-error]
        thePixelDet.->clearBadRocPositions();
                    ^
RecoTracker/MeasurementDet/plugins/MeasurementTrackerImpl.cc:430:19: error: expected unqualified-id [clang-diagnostic-error]
      thePixelDet.->setActive(true);  // module ON
                  ^
Suppressed 1533 warnings (1532 in non-user code, 1 with check filters).
--
DataFormats/Common/interface/Wrapper.h:92:80: error: no matching constructor for initialization of 'MkFitInputWrapper' [clang-diagnostic-error]
  Wrapper<T>::Wrapper(Emplace, Args&&... args) : WrapperBase(), present(true), obj(std::forward<Args>(args)...) {}
                                                                               ^
FWCore/Framework/interface/Event.h:448:43: note: in instantiation of function template specialization 'edm::Wrapper<MkFitInputWrapper>::Wrapper<MkFitHitIndexMap, std::vector<std::vector<mkfit::Hit, std::allocator<mkfit::Hit> >, std::allocator<std::vector<mkfit::Hit, std::allocator<mkfit::Hit> > > >, std::vector<mkfit::Track, std::allocator<mkfit::Track> >, mkfit::LayerNumberConverter &>' requested here
--
gmake: *** [config/SCRAM/GMake/Makefile.coderules:128: code-checks] Error 2
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

fwyzard · 2020-05-19T17:44:45Z

To be replaced by a separate PRs for each individual option that is being enabled.

Enable additional code checks

17fa4a7

cmsbuild added this to the CMSSW_11_1_X milestone May 17, 2020

fwyzard mentioned this pull request May 17, 2020

Enable additional code checks #29858

Closed

cmsbuild added code-checks-rejected and removed code-checks-pending labels May 17, 2020

cmsbuild mentioned this pull request May 17, 2020

[Payload Inspector] Add more SiPixel inspection classes #29864

Merged

fwyzard mentioned this pull request May 18, 2020

Apply existing clang-tidy checks #29866

Closed

fwyzard closed this May 19, 2020

fwyzard deleted the enable_additional_code_checks_effect branch May 19, 2020 17:44

fwyzard mentioned this pull request May 21, 2020

[RFC] Test clang-tidy --checks performance-for-range-copy #29927

Closed

fwyzard restored the enable_additional_code_checks_effect branch May 21, 2020 22:21

fwyzard deleted the enable_additional_code_checks_effect branch May 21, 2020 22:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable additional code checks (effect of #29858) #29863

Enable additional code checks (effect of #29858) #29863

fwyzard commented May 17, 2020

cmsbuild commented May 17, 2020

cmsbuild commented May 17, 2020

fwyzard commented May 19, 2020

Enable additional code checks (effect of #29858) #29863

Enable additional code checks (effect of #29858) #29863

Conversation

fwyzard commented May 17, 2020

cmsbuild commented May 17, 2020

cmsbuild commented May 17, 2020

fwyzard commented May 19, 2020