Tau decay hook #29557
Closed
Tau decay hook #29557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to help avoid the case where the PSet CkfBaseTrajectoryFilter_block is added to a module configuration via a refToPSet_ but is not itself added to the Process we now import that PSet into the cfi files which reference it. The missing reference error happened when the fastsim configuration was changed to more fully utilize eras. This broke the configurations used to generate pileup for fastsim (since only part of the RECO sequence is used).
…_94X New fastsim geometry - backport to 94X
…ressions of Modifiers For these to work I had to bypass the isChosen() checks of the contained Modifiers as they may not be enabled.
…r _{And,Invert,Or}Modifier
Using the same bypass of contained-Modifier isChosen() status as with toModify()
It's a bit simpler to avoid traversing the tree of Modifiers back to some leaf.
extend Modifier boolean expressions to include "not" and "or" [94X]
- Both the nominal and the decorrelated versions are included, as well as a few meta taggers (aggregating the scores). - Currently it supports only updating a jet collection. The implementation to run on RECO exists but not tested.
Re-bind executor every time for thread-safety.
|
The code-checks are being triggered in jenkins. |
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29557/14850
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
-1 wrong branch or repo |
This was referenced Apr 24, 2020
|
All I want to do is make a minor change to GeneratorInterface/Pythia8Interface.
How do I do that when my fork of cmssw is way out of synch with the current developments in other parts that aren’t important to this change?
Steve
From: Slava Krutelyov <notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.com>
Date: Friday, April 24, 2020 at 8:02 AM
To: cms-sw/cmssw <cmssw@noreply.github.com>
Cc: Stephen Mrenna <mrenna@fnal.gov>, Author <author@noreply.github.com>
Subject: Re: [cms-sw/cmssw] Tau decay hook (#29557)
…-1
wrong branch or repo
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cms-2Dsw_cmssw_pull_29557-23issuecomment-2D618994902&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=--2j5dG16WmmzoVJh1OzEtYcvcMILxO2WWZsLuTj0fY&s=8UYkzsI9OwReCePgP7cz_-r8hqdpnX1BUR0yu1vAoAE&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABLSEJBVDQ3N7B6STNSWN5DROGEXXANCNFSM4MQBZKQQ&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=--2j5dG16WmmzoVJh1OzEtYcvcMILxO2WWZsLuTj0fY&s=_Gm4aiwcI7RJTwRSt1YJgFu752reWU9eRNutm1Phiis&e=>.
|
|
@smrenna it's best to check out a new CMSSW release (like CMSSW_11_1_0_pre6), then add the package you want to modify. It will pull from the official repository, thereby getting the latest developments. |
|
That was what I originally tried, but it did not work at all.
It complained about permission.
From: Kevin Pedro <notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.com>
Date: Friday, April 24, 2020 at 2:27 PM
To: cms-sw/cmssw <cmssw@noreply.github.com>
Cc: Stephen Mrenna <mrenna@fnal.gov>, Mention <mention@noreply.github.com>
Subject: Re: [cms-sw/cmssw] Tau decay hook (#29557)
@smrenna<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_smrenna&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=us6yMxmO_ongDg2ZNafpgtM9Kv6gAU5vlJB0h8YMK-E&s=bdMVSV8fYfXF6NzQSytVn1WK7wtwKnVXpXhHDsO6GJ0&e=> it's best to check out a new CMSSW release (like CMSSW_11_1_0_pre6), then add the package you want to modify. It will pull from the official repository, thereby getting the latest developments.
cmsrel CMSSW_11_1_0_pre6
cd CMSSW_11_1_0_pre6/src
cmsenv
git cms-addpkg GeneratorInterface/Pythia8Interface
git checkout -b tauDecayHook2
[make changes, commit changes]
git push my-cmssw tauDecayHook2
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cms-2Dsw_cmssw_pull_29557-23issuecomment-2D619199457&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=us6yMxmO_ongDg2ZNafpgtM9Kv6gAU5vlJB0h8YMK-E&s=gn21_04JMXhtoZL_-APDkX0d9__8hrMeTArgiMmI_UM&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABLSEJBPTEZDFCI65HOQVJLROHRYBANCNFSM4MQBZKQQ&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=us6yMxmO_ongDg2ZNafpgtM9Kv6gAU5vlJB0h8YMK-E&s=E9itop1b_cEAg0bA-7kjyM509UaAS2XOfMS9YukjZLQ&e=>.
|
|
Perhaps the ssh key for your GitHub account was missing? |
This was referenced Apr 25, 2020
|
Hi, Kevin,
Setting the key worked, but what happens when you get put onto a different cms lpc node?
Is the key associated with the cmslpc account, or the particular machine on which you do the commit?
Steve
From: Kevin Pedro <notifications@github.com>
Reply-To: cms-sw/cmssw <reply@reply.github.com>
Date: Friday, April 24, 2020 at 4:52 PM
To: cms-sw/cmssw <cmssw@noreply.github.com>
Cc: Stephen Mrenna <mrenna@fnal.gov>, Mention <mention@noreply.github.com>
Subject: Re: [cms-sw/cmssw] Tau decay hook (#29557)
Perhaps the ssh key for your GitHub account was missing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_cms-2Dsw_cmssw_pull_29557-23issuecomment-2D619254190&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=SMH494WVQc398sql9xGtFPacyVSExw-ui2WUGm89RqM&s=R6A32LhQTvFVFp2s6JPPwXcsab82Ge2_G0WJB-bIZSQ&e=>, or unsubscribe<https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_ABLSEJD2PZXGRGZL7UUPQS3ROICYXANCNFSM4MQBZKQQ&d=DwMCaQ&c=gRgGjJ3BkIsb5y6s49QqsA&r=P6TR6eMSzDEOLYeqW0ECsQ&m=SMH494WVQc398sql9xGtFPacyVSExw-ui2WUGm89RqM&s=97kUvbl8O98i3Cn-__awcWG0k3HZS7CXYFEGKAqEaL8&e=>.
|
|
The filesystem on cmslpc is shared among all nodes, so you should be able to use your key on any of them. |
|
Second attempt in tauDecayHook2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[WIP] A new UserHook in Pythia8 that forces the decay of taus at the process level. At this point, one should be able to select only tau decays to leptons, but that has not been implemented yet. It did not work properly with ResonanceDecayFilter, even though the taus are clearly decayed.