-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DQMOffline: Clean up some unused folders in DQMOffline/Muon package #29548
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29548/14833
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29548/14853
|
A new Pull Request was created by @calderona for master. It involves the following packages: DQMOffline/Configuration @andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
There is a change that has not to be removed.. so better close this PR, and I will open a new one with the correct change. |
PR description:
In agreement with the DQM and Muon groups we have removed some unused folders in the DQMOffline/Muon package. This includes the following folders:
DTSegmentMonitor
TestSummary
Test
Also the QualityTest sequences for muons is removed under DQMOffline/Configuration, since are not really up-to date.
PR validation:
Full sequence have been tested on MC for relval ZMuMu and Cosmics samples.