Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQMOffline: Clean up some unused folders in DQMOffline/Muon package #29548

Closed
wants to merge 10 commits into from

Conversation

calderona
Copy link
Contributor

PR description:

In agreement with the DQM and Muon groups we have removed some unused folders in the DQMOffline/Muon package. This includes the following folders:
DTSegmentMonitor
TestSummary
Test

Also the QualityTest sequences for muons is removed under DQMOffline/Configuration, since are not really up-to date.

PR validation:

Full sequence have been tested on MC for relval ZMuMu and Cosmics samples.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29548/14833

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-29548/14853

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @calderona for master.

It involves the following packages:

DQMOffline/Configuration
DQMOffline/Muon

@andrius-k, @kmaeshima, @schneiml, @cmsbuild, @jfernan2, @fioriNTU can you please review it and eventually sign? Thanks.
@barvic, @threus, @abbiendi, @Fedespring, @bellan, @HuguesBrun, @jhgoh, @ptcox, @cericeci, @trocino, @folguera, @rociovilar this is something you requested to watch as well.
@silviodonato, @dpiparo you are the release manager for this.

cms-bot commands are listed here

@jfernan2
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 24, 2020

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/5853/console Started: 2020/04/24 17:41

@cmsbuild
Copy link
Contributor

+1
Tested at: c76c0bd
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39b99b/5853/summary.html
CMSSW: CMSSW_11_1_X_2020-04-24-1100
SCRAM_ARCH: slc7_amd64_gcc820

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39b99b/5853/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 34
  • DQMHistoTests: Total histograms compared: 2691897
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2691577
  • DQMHistoTests: Total skipped: 319
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -642.527 KiB( 33 files compared)
  • DQMHistoSizes: changed ( 1000.0,... ): -5.289 KiB Muons/DTSegmentsMonitor
  • DQMHistoSizes: changed ( 1000.0,... ): -4.919 KiB Muons_miniAOD/EfficiencyAnalyzer
  • DQMHistoSizes: changed ( 1000.0,... ): -4.286 KiB Muons/EfficiencyAnalyzer
  • DQMHistoSizes: changed ( 1000.0,... ): -2.624 KiB Muons/Tests
  • DQMHistoSizes: changed ( 1000.0,... ): -1.925 KiB Muons/EventInfo
  • DQMHistoSizes: changed ( 1000.0,... ): -1.783 KiB Muons/MuonRecoAnalyzer
  • DQMHistoSizes: changed ( 1000.0,... ): -0.964 KiB Muons/TestSummary
  • DQMHistoSizes: changed ( 1000.0,... ): -0.417 KiB Muons_miniAOD/TriggerMatchMonitor
  • DQMHistoSizes: changed ( 10024.0,... ): -1.955 KiB Muons_miniAOD/MuonRecoAnalyzer
  • DQMHistoSizes: changed ( 4.22,... ): -5.321 KiB Muons/cosmicMuons
  • DQMHistoSizes: changed ( 4.22 ): ...
  • Checked 147 log files, 16 edm output root files, 34 DQM output files

@calderona
Copy link
Contributor Author

There is a change that has not to be removed.. so better close this PR, and I will open a new one with the correct change.

@calderona calderona closed this Apr 26, 2020
@calderona calderona deleted the muonDQM_clean branch April 26, 2020 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants